Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5748)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc

Issue 2857963002: Revert "[PageLoadMetrics] Keep track of Ad Sizes on Pages" (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
index b13c27022a8a5c1542b5e036c78a5d46bc8e72c4..51674a90a554c47aa50ed33e5bf64a8ac73b5b0d 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
@@ -418,14 +418,9 @@ TEST_F(DataReductionProxyMetricsObserverTest, OnCompletePingback) {
data->set_lofi_received(true);
// Verify LoFi is tracked when a LoFi response is received.
-
page_load_metrics::ExtraRequestCompleteInfo resource = {
- GURL(),
- -1 /* frame_tree_node_id */,
- true /*was_cached*/,
- 1024 * 40 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
- std::move(data),
+ true /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ 0 /* original_network_content_length */, std::move(data),
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME};
RunTest(true, false);
@@ -461,24 +456,21 @@ TEST_F(DataReductionProxyMetricsObserverTest, ByteInformationCompression) {
// Prepare 4 resources of varying size and configurations.
page_load_metrics::ExtraRequestCompleteInfo resources[] = {
// Cached request.
- {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
- 1024 * 40 /* raw_body_bytes */, 0 /* original_network_content_length */,
+ {true /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ 0 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */,
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached non-proxied request.
- {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
- 1024 * 40 /* raw_body_bytes */,
+ {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */,
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached proxied request with .1 compression ratio.
- {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
- 1024 * 40 /* raw_body_bytes */,
+ {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
1024 * 40 * 10 /* original_network_content_length */, data->DeepCopy(),
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached proxied request with .5 compression ratio.
- {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
- 1024 * 40 /* raw_body_bytes */,
+ {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
1024 * 40 * 5 /* original_network_content_length */, std::move(data),
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
};
@@ -520,24 +512,21 @@ TEST_F(DataReductionProxyMetricsObserverTest, ByteInformationInflation) {
// Prepare 4 resources of varying size and configurations.
page_load_metrics::ExtraRequestCompleteInfo resources[] = {
// Cached request.
- {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
- 1024 * 40 /* raw_body_bytes */, 0 /* original_network_content_length */,
+ {true /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ 0 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */,
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached non-proxied request.
- {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
- 1024 * 40 /* raw_body_bytes */,
+ {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */,
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached proxied request with .1 compression ratio.
- {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
- 1024 * 40 * 10 /* raw_body_bytes */,
+ {false /*was_cached*/, 1024 * 40 * 10 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */, data->DeepCopy(),
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
// Uncached proxied request with .5 compression ratio.
- {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
- 1024 * 40 * 5 /* raw_body_bytes */,
+ {false /*was_cached*/, 1024 * 40 * 5 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */, std::move(data),
content::ResourceType::RESOURCE_TYPE_MAIN_FRAME},
};

Powered by Google App Engine
This is Rietveld 408576698