Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2857863003: getScreenCTM on <use> should not include the additional translation (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

getScreenCTM on <use> should not include the additional translation This is a partial revert of https://codereview.chromium.org/2711503002, preserving the fix from that bug (crbug.com/678167) while restoring the LocalCoordinateSpaceTransform() infrastructure to compute the correct CTM for <use> elements. BUG=716711 Review-Url: https://codereview.chromium.org/2853223002 Cr-Commit-Position: refs/heads/master@{#468657} (cherry picked from commit 9acc325d119247a27d0a007d56fc6cc2fa23edc7) Review-Url: https://codereview.chromium.org/2857863003 . Cr-Commit-Position: refs/branch-heads/3071@{#370} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/351c73cdc0a9a1e1391893f1b44f40e419950b9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -43 lines) Patch
A third_party/WebKit/LayoutTests/svg/dom/getscreenctm-use-with-additional-translation.html View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp View 4 chunks +3 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPatternElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPatternElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +33 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
fs
3 years, 7 months ago (2017-05-03 07:56:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
351c73cdc0a9a1e1391893f1b44f40e419950b9f.

Powered by Google App Engine
This is Rietveld 408576698