Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2853223002: getScreenCTM on <use> should not include the additional translation (Closed)

Created:
3 years, 7 months ago by fs
Modified:
3 years, 7 months ago
Reviewers:
Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

getScreenCTM on <use> should not include the additional translation This is a partial revert of https://codereview.chromium.org/2711503002, preserving the fix from that bug (crbug.com/678167) while restoring the LocalCoordinateSpaceTransform() infrastructure to compute the correct CTM for <use> elements. BUG=716711 Review-Url: https://codereview.chromium.org/2853223002 Cr-Commit-Position: refs/heads/master@{#468657} Committed: https://chromium.googlesource.com/chromium/src/+/9acc325d119247a27d0a007d56fc6cc2fa23edc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -43 lines) Patch
A third_party/WebKit/LayoutTests/svg/dom/getscreenctm-use-with-additional-translation.html View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp View 4 chunks +3 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPatternElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPatternElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +33 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
fs
3 years, 7 months ago (2017-05-02 11:18:11 UTC) #4
Stephen Chennney
lgtm
3 years, 7 months ago (2017-05-02 15:54:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2853223002/1
3 years, 7 months ago (2017-05-02 16:00:14 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 16:05:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9acc325d119247a27d0a007d56fc...

Powered by Google App Engine
This is Rietveld 408576698