Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2857663002: Reland "Use new SafeBrowsing redirect tracking code in CWS pings."" (Closed)

Created:
3 years, 7 months ago by robertshield
Modified:
3 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Use new SafeBrowsing redirect tracking code in CWS pings."" (patchset #6 id:140001 of https://codereview.chromium.org/2779643002/ ) This reverts commit 9fb1c8b9feec6f43c99eca8cecf09a5582c254f7. It relands the original patch by fixing an uninitialized read in the related browser test. BUG=685905, 717315 Review-Url: https://codereview.chromium.org/2857663002 Cr-Commit-Position: refs/heads/master@{#469006} Committed: https://chromium.googlesource.com/chromium/src/+/1547f4c5289b094a0d0487e6c54297cede4d5db7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -30 lines) Patch
M chrome/browser/extensions/webstore_inline_installer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 4 chunks +74 lines, -20 lines 0 comments Download
M chrome/browser/extensions/webstore_inline_installer_browsertest.cc View 10 chunks +55 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
robertshield
Hi Devlin, would you mind taking a quick look? This is identical to https://codereview.chromium.org/2779643002/ except ...
3 years, 7 months ago (2017-05-02 19:31:00 UTC) #6
Devlin
lgtm. One title nit: s/Revert "Revert of Use..."/Reland "Use..." And a tip for future reference: ...
3 years, 7 months ago (2017-05-03 15:49:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857663002/1
3 years, 7 months ago (2017-05-03 16:01:57 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 16:53:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1547f4c5289b094a0d0487e6c542...

Powered by Google App Engine
This is Rietveld 408576698