[Reland][gin] Add Arguments::GetAll()

[Reland][gin] Add Arguments::GetAll()

Add an Arguments::GetAll() function that returns all arguments as a
std::vector<v8::Local<v8::Value>>. This is more clear, concise, and
slightly more performant than the alternative of using
Arguments::GetRemaining() since it doesn't require trying to convert
and avoids unnecessary calls.

Add a test for the new method.

Reverted due to a compile error, now fixed.

BUG=None

Review-Url: https://codereview.chromium.org/2822373002
Cr-Commit-Position: refs/heads/master@{#465627}
Committed: https://chromium.googlesource.com/chromium/src/+/cd675450f3ecf0afadb537c18cbe29aaed80164e

[Devlin, 2017-04-19 00:37:11]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 00:37:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-04-19 00:40:42]

rdevlin.cronin@chromium.org changed reviewers:
+ jochen@chromium.org

[Devlin, 2017-04-19 00:40:42]

Jochen, mind taking another quick look?  Only difference from the original at
https://codereview.chromium.org/2824883002/ is the cast.  (Didn't compile on a
windows machine before, d'oh)

[commit-bot: I haz the power, 2017-04-19 00:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 00:43:55]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[jochen (gone - plz use gerrit), 2017-04-19 10:15:50]

lgtm

[Devlin, 2017-04-19 15:04:52]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 15:05:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 16:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 16:05:58]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-04-19 16:09:40]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-04-19 16:10:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 16:14:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492618180027490,
"parent_rev": "b51016bc5eadfff20090ae68334776f6d6d11772", "commit_rev":
"cd675450f3ecf0afadb537c18cbe29aaed80164e"}

[commit-bot: I haz the power, 2017-04-19 16:14:25]

Description was changed from

==========
[Reland][gin] Add Arguments::GetAll()

Add an Arguments::GetAll() function that returns all arguments as a
std::vector<v8::Local<v8::Value>>. This is more clear, concise, and
slightly more performant than the alternative of using
Arguments::GetRemaining() since it doesn't require trying to convert
and avoids unnecessary calls.

Add a test for the new method.

Reverted due to a compile error, now fixed.

BUG=None
==========

to

==========
[Reland][gin] Add Arguments::GetAll()

Add an Arguments::GetAll() function that returns all arguments as a
std::vector<v8::Local<v8::Value>>. This is more clear, concise, and
slightly more performant than the alternative of using
Arguments::GetRemaining() since it doesn't require trying to convert
and avoids unnecessary calls.

Add a test for the new method.

Reverted due to a compile error, now fixed.

BUG=None

Review-Url: https://codereview.chromium.org/2822373002
Cr-Commit-Position: refs/heads/master@{#465627}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd675450f3ecf0afadb537c18cbe...
==========

[commit-bot: I haz the power, 2017-04-19 16:14:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cd675450f3ecf0afadb537c18cbe...