chrome/browser/ui/extensions/extension_action_view_controller.cc - Issue 2857653002: Fix BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval in ASan with new libc++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_action_view_controller.cc

Issue 2857653002: Fix BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval in ASan with new libc++. (Closed)

Patch Set: worse! Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/extension_action_view_controller.cc

diff --git a/chrome/browser/ui/extensions/extension_action_view_controller.cc b/chrome/browser/ui/extensions/extension_action_view_controller.cc

index 7ce2454c048a5e8ef8457c4c30fa717a23d1d547..209ae71115b0d912f0535c3c8e291c57186d8ff6 100644

--- a/chrome/browser/ui/extensions/extension_action_view_controller.cc

+++ b/chrome/browser/ui/extensions/extension_action_view_controller.cc

@@ -74,8 +74,7 @@ void ExtensionActionViewController::SetDelegate(

view_delegate_ = delegate;

platform_delegate_->OnDelegateSet();

} else {

- if (is_showing_popup())

- HidePopup();

+ DCHECK(!is_showing_popup());

platform_delegate_.reset();

view_delegate_ = nullptr;

}