Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

Issue 2857653002: Fix BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval in ASan with new libc++. (Closed)
Patch Set: worse! Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
index e492bdb763f01dbc9ba333ea2d9dc662925ceaee..6c1e1b5d0e3140fa009eb04916c23d87f3e442ca 100644
--- a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
@@ -513,6 +513,8 @@ void ToolbarActionsBarBridge::ShowToolbarActionBubble(
base::scoped_nsobject<BrowserActionButton> button(
[[self buttonForId:action->GetId()] retain]);
+ [button hidePopup];
+
// Note: We remove the button from the view and the buttons list first because
// destroying it (or calling -onRemoved) can cause redraws, and we don't want
// to include it when the view is gone.

Powered by Google App Engine
This is Rietveld 408576698