chrome/browser/ui/toolbar/toolbar_actions_bar.cc - Issue 2857653002: Fix BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval in ASan with new libc++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_bar.cc

Issue 2857653002: Fix BrowserActionsBarBrowserTest.OverflowedBrowserActionPopupTestRemoval in ASan with new libc++. (Closed)

Patch Set: worse! Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/toolbar_actions_bar.cc

diff --git a/chrome/browser/ui/toolbar/toolbar_actions_bar.cc b/chrome/browser/ui/toolbar/toolbar_actions_bar.cc

index fd0bbf0237042b107005b7cfcae02ed2da6c41af..33fb5957f65dd56bc32df043c50a18f4b468870a 100644

--- a/chrome/browser/ui/toolbar/toolbar_actions_bar.cc

+++ b/chrome/browser/ui/toolbar/toolbar_actions_bar.cc

@@ -659,8 +659,6 @@ void ToolbarActionsBar::OnToolbarActionRemoved(const std::string& action_id) {

std::move(*iter);

toolbar_actions_.erase(iter);

delegate_->RemoveViewForAction(removed_action.get());

- if (popped_out_action_ == removed_action.get())

- UndoPopOut();

removed_action.reset();

// If the extension is being upgraded we don't want the bar to shrink