Let google::Symbolize only print address offset in sanitizer builds.

Let google::Symbolize only print address offset in sanitizer builds.

Sanitizer stacks are supposed to be run through
tools/valgrind/asan/asan_symbolize.py anyhow, which calls llvm-symbolizer.
llvm-symbolizer can do a better job at symbolizing than google::Symbolize
if google::Symbolize doesn't throw away the data llvm-symbolizer needs.

Stack before (both with and without filtering through asan_symbolize):

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x0000007ea911 __interceptor_backtrace
#1 0x0000082e2afc base::debug::StackTrace::StackTrace()
#2 0x00000979d5ce content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f04d9814cb0 <unknown>
#4 0x00000fbd5624 BrowserActionsContainer::Layout()
#5 0x00000fbd3c3e BrowserActionsContainer::Redraw()
#6 0x00000f91d38e ToolbarActionsBar::UndoPopOut()


Stack after, not filtered through asan_symbolize:

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x0000007ea911 (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x7ea910)
#1 0x0000082e2afc (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x82e2afb)
#2 0x00000979d5ce (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x979d5cd)
#3 0x7fbcf8399cb0 (/lib/x86_64-linux-gnu/libc-2.19.so+0x36caf)
#4 0x00000fbc96b4 (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xfbc96b3)
#5 0x00000fbc7cce (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xfbc7ccd)
#6 0x00000f91141e (/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xf91141d)


Stack after, filtered through asan_symbolize:

BrowserTestBase received signal: Segmentation fault. Backtrace:
    #0 0x0000007ea911 in __interceptor_backtrace ??:0:0
    #1 0x0000082e2afc in base::debug::StackTrace::StackTrace(unsigned long) /usr/local/google/home/thakis/src/chrome/src/out/asan/../../base/debug/stack_trace_posix.cc:745:41
    #2 0x00000979d5ce in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) /usr/local/google/home/thakis/src/chrome/src/out/asan/../../content/public/test/browser_test_base.cc:80:5
    #3 0x7fda947f5cb0 in killpg ??:?
    #4 0x7fda947f5cb0 in ?? ??:0
    #5 0x00000fbc96b4 in BrowserActionsContainer::Layout() /usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/views/toolbar/browser_actions_container.cc:364:13
    #6 0x00000fbc7cce in BrowserActionsContainer::Redraw(bool) /usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/views/toolbar/browser_actions_container.cc:214:3
    #7 0x00000f91141e in ToolbarActionsBar::UndoPopOut() /usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/toolbar/toolbar_actions_bar.cc:534:16


BUG=none

Review-Url: https://codereview.chromium.org/2857643002
Cr-Commit-Position: refs/heads/master@{#469311}
Committed: https://chromium.googlesource.com/chromium/src/+/ea46669e9b3d8c7a64e9c2280629a030a9e5e88b

[Nico, 2017-05-02 15:13:29]

Description was changed from

==========
Let google::Symbolize only print address offset in sanitizer builds.

Sanitizer stacks are supposed to be run through
tools/valgrind/asan/asan_symbolize.py anyhow, which calls llvm-symbolizer.
llvm-symbolizer can do a better job at symbolizing than google::Symbolize
if google::Symbolize doesn't throw away the data llvm-symbolizer needs.

BUG=none
==========

to

==========
Let google::Symbolize only print address offset in sanitizer builds.

Sanitizer stacks are supposed to be run through
tools/valgrind/asan/asan_symbolize.py anyhow, which calls llvm-symbolizer.
llvm-symbolizer can do a better job at symbolizing than google::Symbolize
if google::Symbolize doesn't throw away the data llvm-symbolizer needs.

Stack before (both with and without filtering through asan_symbolize):

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x0000007ea911 __interceptor_backtrace
#1 0x0000082e2afc base::debug::StackTrace::StackTrace()
#2 0x00000979d5ce content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f04d9814cb0 <unknown>
#4 0x00000fbd5624 BrowserActionsContainer::Layout()
#5 0x00000fbd3c3e BrowserActionsContainer::Redraw()
#6 0x00000f91d38e ToolbarActionsBar::UndoPopOut()


Stack after, not filtered through asan_symbolize:

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x0000007ea911
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x7ea910)
#1 0x0000082e2afc
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x82e2afb)
#2 0x00000979d5ce
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x979d5cd)
#3 0x7fbcf8399cb0 (/lib/x86_64-linux-gnu/libc-2.19.so+0x36caf)
#4 0x00000fbc96b4
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xfbc96b3)
#5 0x00000fbc7cce
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xfbc7ccd)
#6 0x00000f91141e
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xf91141d)


Stack after, filtered through asan_symbolize:

BrowserTestBase received signal: Segmentation fault. Backtrace:
    #0 0x0000007ea911 in __interceptor_backtrace ??:0:0
    #1 0x0000082e2afc in base::debug::StackTrace::StackTrace(unsigned long)
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../base/debug/stack_trace_posix.cc:745:41
    #2 0x00000979d5ce in content::(anonymous
namespace)::DumpStackTraceSignalHandler(int)
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../content/public/test/browser_test_base.cc:80:5
    #3 0x7fda947f5cb0 in killpg ??:?
    #4 0x7fda947f5cb0 in ?? ??:0
    #5 0x00000fbc96b4 in BrowserActionsContainer::Layout()
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/views/toolbar/browser_actions_container.cc:364:13
    #6 0x00000fbc7cce in BrowserActionsContainer::Redraw(bool)
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/views/toolbar/browser_actions_container.cc:214:3
    #7 0x00000f91141e in ToolbarActionsBar::UndoPopOut()
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/toolbar/toolbar_actions_bar.cc:534:16


BUG=none
==========

[Nico, 2017-05-02 15:16:17]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org, thestig@chromium.org

[Nico, 2017-05-02 15:16:18]

Not sure if this is a good change or not. Opinions?

[dcheng, 2017-05-02 19:12:15]

lgtm

[dcheng, 2017-05-02 19:12:24]

(I think it's strictly better)

[Lei Zhang, 2017-05-02 19:14:45]

++lgtm

[Lei Zhang, 2017-05-02 19:18:41]

https://codereview.chromium.org/2857643002/diff/1/base/third_party/symbolize/...
File base/third_party/symbolize/symbolize.cc (right):

https://codereview.chromium.org/2857643002/diff/1/base/third_party/symbolize/...
base/third_party/symbolize/symbolize.cc:776: #if !defined(ADDRESS_SANITIZER) &&
!defined(LEAK_SANITIZER) && \
Alternatively, use the #if to set some constant, and use that on line 778 so it
always returns true? Then you don't have to write the #if twice.

[Nico, 2017-05-02 20:18:27]

Thanks!

https://codereview.chromium.org/2857643002/diff/1/base/third_party/symbolize/...
File base/third_party/symbolize/symbolize.cc (right):

https://codereview.chromium.org/2857643002/diff/1/base/third_party/symbolize/...
base/third_party/symbolize/symbolize.cc:776: #if !defined(ADDRESS_SANITIZER) &&
!defined(LEAK_SANITIZER) && \
On 2017/05/02 19:18:41, Lei Zhang wrote:
> Alternatively, use the #if to set some constant, and use that on line 778 so
it
> always returns true? Then you don't have to write the #if twice.

It's somewhat less icky, but still icky, so I think I don't want to invalidate
my completed try run for this :-)

[Nico, 2017-05-02 20:18:30]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-05-02 20:19:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 21:24:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 21:24:19]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2017-05-03 19:02:16]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2017-05-03 19:03:07]

I also had to disable two tests that check that stacks are symbolized. If you
see a problem with that, please uncheck cq. (I'm assuming you don't, since the
test just repeats what I said in the CL description.)

[Nico, 2017-05-03 19:03:15]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-05-03 19:03:19]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-05-03 19:03:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2857643002/#ps20001
(title: "test")

[commit-bot: I haz the power, 2017-05-03 19:03:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 19:12:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 19:12:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2017-05-03 19:13:46]

thakis@chromium.org changed reviewers:
+ sky@chromium.org

[Nico, 2017-05-03 19:13:46]

+sky for content/test/OWNERS

[sky, 2017-05-04 03:46:47]

LGTM

[Nico, 2017-05-04 11:34:47]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-05-04 11:35:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 11:39:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493897687768330,
"parent_rev": "30412471dcf0fd93d53675067a7832b74f85cc79", "commit_rev":
"ea46669e9b3d8c7a64e9c2280629a030a9e5e88b"}

[commit-bot: I haz the power, 2017-05-04 11:39:43]

Description was changed from

==========
Let google::Symbolize only print address offset in sanitizer builds.

Sanitizer stacks are supposed to be run through
tools/valgrind/asan/asan_symbolize.py anyhow, which calls llvm-symbolizer.
llvm-symbolizer can do a better job at symbolizing than google::Symbolize
if google::Symbolize doesn't throw away the data llvm-symbolizer needs.

Stack before (both with and without filtering through asan_symbolize):

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x0000007ea911 __interceptor_backtrace
#1 0x0000082e2afc base::debug::StackTrace::StackTrace()
#2 0x00000979d5ce content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f04d9814cb0 <unknown>
#4 0x00000fbd5624 BrowserActionsContainer::Layout()
#5 0x00000fbd3c3e BrowserActionsContainer::Redraw()
#6 0x00000f91d38e ToolbarActionsBar::UndoPopOut()


Stack after, not filtered through asan_symbolize:

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x0000007ea911
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x7ea910)
#1 0x0000082e2afc
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x82e2afb)
#2 0x00000979d5ce
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x979d5cd)
#3 0x7fbcf8399cb0 (/lib/x86_64-linux-gnu/libc-2.19.so+0x36caf)
#4 0x00000fbc96b4
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xfbc96b3)
#5 0x00000fbc7cce
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xfbc7ccd)
#6 0x00000f91141e
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xf91141d)


Stack after, filtered through asan_symbolize:

BrowserTestBase received signal: Segmentation fault. Backtrace:
    #0 0x0000007ea911 in __interceptor_backtrace ??:0:0
    #1 0x0000082e2afc in base::debug::StackTrace::StackTrace(unsigned long)
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../base/debug/stack_trace_posix.cc:745:41
    #2 0x00000979d5ce in content::(anonymous
namespace)::DumpStackTraceSignalHandler(int)
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../content/public/test/browser_test_base.cc:80:5
    #3 0x7fda947f5cb0 in killpg ??:?
    #4 0x7fda947f5cb0 in ?? ??:0
    #5 0x00000fbc96b4 in BrowserActionsContainer::Layout()
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/views/toolbar/browser_actions_container.cc:364:13
    #6 0x00000fbc7cce in BrowserActionsContainer::Redraw(bool)
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/views/toolbar/browser_actions_container.cc:214:3
    #7 0x00000f91141e in ToolbarActionsBar::UndoPopOut()
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/toolbar/toolbar_actions_bar.cc:534:16


BUG=none
==========

to

==========
Let google::Symbolize only print address offset in sanitizer builds.

Sanitizer stacks are supposed to be run through
tools/valgrind/asan/asan_symbolize.py anyhow, which calls llvm-symbolizer.
llvm-symbolizer can do a better job at symbolizing than google::Symbolize
if google::Symbolize doesn't throw away the data llvm-symbolizer needs.

Stack before (both with and without filtering through asan_symbolize):

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x0000007ea911 __interceptor_backtrace
#1 0x0000082e2afc base::debug::StackTrace::StackTrace()
#2 0x00000979d5ce content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f04d9814cb0 <unknown>
#4 0x00000fbd5624 BrowserActionsContainer::Layout()
#5 0x00000fbd3c3e BrowserActionsContainer::Redraw()
#6 0x00000f91d38e ToolbarActionsBar::UndoPopOut()


Stack after, not filtered through asan_symbolize:

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x0000007ea911
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x7ea910)
#1 0x0000082e2afc
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x82e2afb)
#2 0x00000979d5ce
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0x979d5cd)
#3 0x7fbcf8399cb0 (/lib/x86_64-linux-gnu/libc-2.19.so+0x36caf)
#4 0x00000fbc96b4
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xfbc96b3)
#5 0x00000fbc7cce
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xfbc7ccd)
#6 0x00000f91141e
(/usr/local/google/home/thakis/src/chrome/src/out/asan/browser_tests+0xf91141d)


Stack after, filtered through asan_symbolize:

BrowserTestBase received signal: Segmentation fault. Backtrace:
    #0 0x0000007ea911 in __interceptor_backtrace ??:0:0
    #1 0x0000082e2afc in base::debug::StackTrace::StackTrace(unsigned long)
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../base/debug/stack_trace_posix.cc:745:41
    #2 0x00000979d5ce in content::(anonymous
namespace)::DumpStackTraceSignalHandler(int)
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../content/public/test/browser_test_base.cc:80:5
    #3 0x7fda947f5cb0 in killpg ??:?
    #4 0x7fda947f5cb0 in ?? ??:0
    #5 0x00000fbc96b4 in BrowserActionsContainer::Layout()
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/views/toolbar/browser_actions_container.cc:364:13
    #6 0x00000fbc7cce in BrowserActionsContainer::Redraw(bool)
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/views/toolbar/browser_actions_container.cc:214:3
    #7 0x00000f91141e in ToolbarActionsBar::UndoPopOut()
/usr/local/google/home/thakis/src/chrome/src/out/asan/../../chrome/browser/ui/toolbar/toolbar_actions_bar.cc:534:16


BUG=none

Review-Url: https://codereview.chromium.org/2857643002
Cr-Commit-Position: refs/heads/master@{#469311}
Committed:
https://chromium.googlesource.com/chromium/src/+/ea46669e9b3d8c7a64e9c2280629...
==========

[commit-bot: I haz the power, 2017-05-04 11:39:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ea46669e9b3d8c7a64e9c2280629...