Let google::Symbolize only print address offset in sanitizer builds.

content/test/content_browser_test_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/test/content_browser_test.h"
 
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/process/launch.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 72 matching lines @@
   base::ThreadRestrictions::ScopedAllowIO allow_io_for_temp_dir;
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   base::CommandLine new_test =
       base::CommandLine(base::CommandLine::ForCurrentProcess()->GetProgram());
   new_test.AppendSwitchASCII(base::kGTestFilterFlag,
                              "ContentBrowserTest.MANUAL_RendererCrash");
   new_test.AppendSwitch(kRunManualTestsFlag);
   new_test.AppendSwitch(kSingleProcessTestsFlag);
 
-  // Per https://www.chromium.org/developers/testing/addresssanitizer, there are
-  // ASAN bots that run without the sandbox which this test will pass for. The
-  // other ones pipe the output to a symbolizer script.
-  if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kNoSandbox)) {
-    new_test.AppendSwitch(switches::kNoSandbox);
-  } else {
-#if defined(ADDRESS_SANITIZER)
-    LOG(INFO) << "Couldn't run ContentBrowserTest.RendererCrashCallStack since "
-              << "sandbox is enabled and ASAN requires piping to an external "
-              << "script.";
-    return;
-#endif
-  }
-
   std::string output;
   base::GetAppOutputAndError(new_test, &output);
 
+  // In sanitizer builds, an external script is responsible for symbolizing,
+  // so the stack that the tests sees here looks like:
+  // "#0 0x0000007ea911 (...content_browsertests+0x7ea910)"
   std::string crash_string =
+#if !defined(ADDRESS_SANITIZER) && !defined(LEAK_SANITIZER) && \
+    !defined(MEMORY_SANITIZER) && !defined(THREAD_SANITIZER)
       "content::RenderFrameImpl::PrepareRenderViewForNavigation";
+#else
+      "#0 ";
+#endif
 
   if (output.find(crash_string) == std::string::npos) {
     GTEST_FAIL() << "Couldn't find\n" << crash_string << "\n in output\n "
                  << output;
   }
 }
 
 IN_PROC_BROWSER_TEST_F(ContentBrowserTest, MANUAL_BrowserCrash) {
   CHECK(false);
 }
 
 // Tests that browser tests print the callstack on asserts.
 IN_PROC_BROWSER_TEST_F(ContentBrowserTest, BrowserCrashCallStack) {
   base::ThreadRestrictions::ScopedAllowIO allow_io_for_temp_dir;
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   base::CommandLine new_test =
       base::CommandLine(base::CommandLine::ForCurrentProcess()->GetProgram());
   new_test.AppendSwitchASCII(base::kGTestFilterFlag,
                              "ContentBrowserTest.MANUAL_BrowserCrash");
   new_test.AppendSwitch(kRunManualTestsFlag);
   new_test.AppendSwitch(kSingleProcessTestsFlag);
   std::string output;
   base::GetAppOutputAndError(new_test, &output);
 
+  // In sanitizer builds, an external script is responsible for symbolizing,
+  // so the stack that the test sees here looks like:
+  // "#0 0x0000007ea911 (...content_browsertests+0x7ea910)"
   std::string crash_string =
-      "content::ContentBrowserTest_MANUAL_BrowserCrash_Test::RunTestOnMainThread";
+#if !defined(ADDRESS_SANITIZER) && !defined(LEAK_SANITIZER) && \
+    !defined(MEMORY_SANITIZER) && !defined(THREAD_SANITIZER)
+      "content::ContentBrowserTest_MANUAL_BrowserCrash_Test::"
+      "RunTestOnMainThread";
+#else
+      "#0 ";
+#endif
 
   if (output.find(crash_string) == std::string::npos) {
     GTEST_FAIL() << "Couldn't find\n" << crash_string << "\n in output\n "
                  << output;
   }
 }
 
 #endif
 
 class ContentBrowserTestSanityTest : public ContentBrowserTest {
@@ skipping 34 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(ContentBrowserTest, NonNestableTask) {
   bool non_nested_task_ran = false;
   base::ThreadTaskRunnerHandle::Get()->PostNonNestableTask(
       FROM_HERE, base::Bind(&CallbackChecker, &non_nested_task_ran));
   content::RunAllPendingInMessageLoop();
   ASSERT_TRUE(non_nested_task_ran);
 }
 
 }  // namespace content