Issue 2857583004: ChromeOS: Correctly handle settings.resolve_device_timezone_by_geolocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2857583004: ChromeOS: Correctly handle settings.resolve_device_timezone_by_geolocation. (Closed)

Created:
3 years, 7 months ago by Alexander Alekseev

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

ChromeOS: Correctly handle settings.resolve_device_timezone_by_geolocation. This CL fixes a problem when checking for if timezone autodetection should startfor signin screen, when unset preference was treated as "false". BUG=622555 Review-Url: https://codereview.chromium.org/2855433002 Cr-Commit-Position: refs/heads/master@{#468491} (cherry picked from commit ad7d3bec4dd219a4675fcb5473186e96039c2b0a) Review-Url: https://codereview.chromium.org/2857583004 . Cr-Commit-Position: refs/branch-heads/3071@{#361} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/156d9dfa385488b1b044122278d1d7764c95e0b7

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	chrome/browser/chromeos/system/timezone_resolver_manager.cc	View		2 chunks	+7 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Alexander Alekseev

3 years, 7 months ago (2017-05-02 20:51:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
156d9dfa385488b1b044122278d1d7764c95e0b7.