Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2855433002: ChromeOS: Correctly handle settings.resolve_device_timezone_by_geolocation. (Closed)

Created:
3 years, 7 months ago by Alexander Alekseev
Modified:
3 years, 7 months ago
Reviewers:
achuithb
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS: Correctly handle settings.resolve_device_timezone_by_geolocation. This CL fixes a problem when checking for if timezone autodetection should startfor signin screen, when unset preference was treated as "false". BUG=622555 Review-Url: https://codereview.chromium.org/2855433002 Cr-Commit-Position: refs/heads/master@{#468491} Committed: https://chromium.googlesource.com/chromium/src/+/ad7d3bec4dd219a4675fcb5473186e96039c2b0a

Patch Set 1 #

Patch Set 2 : Fx build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/chromeos/system/timezone_resolver_manager.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Alexander Alekseev
Please review.
3 years, 7 months ago (2017-04-29 02:10:23 UTC) #2
achuithb
So for start screen, the preference was not set? Is this a regression or has ...
3 years, 7 months ago (2017-05-01 23:01:56 UTC) #11
Alexander Alekseev
On 2017/05/01 23:01:56, achuithb wrote: > So for start screen, the preference was not set? ...
3 years, 7 months ago (2017-05-01 23:10:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2855433002/20001
3 years, 7 months ago (2017-05-01 23:11:58 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 23:47:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ad7d3bec4dd219a4675fcb547318...

Powered by Google App Engine
This is Rietveld 408576698