Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2857523002: Revert of Remove FrameView::Root (Closed)

Created:
3 years, 7 months ago by vabr (Chromium)
Modified:
3 years, 7 months ago
Reviewers:
haraken, joelhockey, dcheng
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove FrameView::Root (patchset #2 id:20001 of https://codereview.chromium.org/2849383002/ ) Reason for revert: This broke compilation (details later). Today's sheriff Original issue's description: > Remove FrameView::Root > > BUG=637460 > > Review-Url: https://codereview.chromium.org/2849383002 > Cr-Commit-Position: refs/heads/master@{#468588} > Committed: https://chromium.googlesource.com/chromium/src/+/561e38ff8dc24f23f0293c54777bbc2eda99a2b5 TBR=haraken@chromium.org,dcheng@chromium.org,joelhockey@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=637460 Review-Url: https://codereview.chromium.org/2857523002 Cr-Commit-Position: refs/heads/master@{#468589} Committed: https://chromium.googlesource.com/chromium/src/+/0cd36b0f1fa2b9778ec33ec9db4ad9bcba094c7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
vabr (Chromium)
Created Revert of Remove FrameView::Root
3 years, 7 months ago (2017-05-02 09:49:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857523002/1
3 years, 7 months ago (2017-05-02 09:50:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0cd36b0f1fa2b9778ec33ec9db4ad9bcba094c7e
3 years, 7 months ago (2017-05-02 09:51:01 UTC) #6
vabr (Chromium)
Details at https://crbug.com/637460#c28
3 years, 7 months ago (2017-05-02 09:52:22 UTC) #7
joelhockey
On 2017/05/02 at 09:52:22, vabr wrote: > Details at https://crbug.com/637460#c28 Thanks vabr. Sorry for this, ...
3 years, 7 months ago (2017-05-02 09:55:54 UTC) #8
vabr (Chromium)
On 2017/05/02 09:55:54, joelhockey wrote: > On 2017/05/02 at 09:52:22, vabr wrote: > > Details ...
3 years, 7 months ago (2017-05-02 10:27:22 UTC) #9
haraken
3 years, 7 months ago (2017-05-02 10:50:54 UTC) #10
Message was sent while issue was closed.
LGTM to revert

Powered by Google App Engine
This is Rietveld 408576698