Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2849383002: Remove FrameView::Root (Closed)

Created:
3 years, 7 months ago by joelhockey
Modified:
3 years, 7 months ago
Reviewers:
haraken, dcheng
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FrameView::Root BUG=637460 Review-Url: https://codereview.chromium.org/2849383002 Cr-Original-Commit-Position: refs/heads/master@{#468588} Committed: https://chromium.googlesource.com/chromium/src/+/561e38ff8dc24f23f0293c54777bbc2eda99a2b5 Review-Url: https://codereview.chromium.org/2849383002 Cr-Commit-Position: refs/heads/master@{#468817} Committed: https://chromium.googlesource.com/chromium/src/+/95b2a74dcc579f928a8abb631a3ad00854924fd0

Patch Set 1 #

Patch Set 2 : Remove FrameView::Root #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
joelhockey
See patch 1 that I ran this testing that GetFrame()->LocalFrameRoot()->View is same as Root().
3 years, 7 months ago (2017-05-02 07:31:44 UTC) #6
dcheng
lgtm
3 years, 7 months ago (2017-05-02 07:38:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849383002/20001
3 years, 7 months ago (2017-05-02 07:54:06 UTC) #9
haraken
LGTM
3 years, 7 months ago (2017-05-02 08:05:19 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/561e38ff8dc24f23f0293c54777bbc2eda99a2b5
3 years, 7 months ago (2017-05-02 09:39:02 UTC) #13
vabr (Chromium)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2857523002/ by vabr@chromium.org. ...
3 years, 7 months ago (2017-05-02 09:49:50 UTC) #14
findit-for-me
Findit (https://goo.gl/kROfz5) confirmed this CL at revision 468588 as the culprit for failures in the ...
3 years, 7 months ago (2017-05-02 09:51:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849383002/40001
3 years, 7 months ago (2017-05-02 10:02:00 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/443413)
3 years, 7 months ago (2017-05-02 11:33:31 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849383002/40001
3 years, 7 months ago (2017-05-02 21:48:42 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 23:35:49 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/95b2a74dcc579f928a8abb631a3a...

Powered by Google App Engine
This is Rietveld 408576698