third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js - Issue 2857453002: DevTools: support resolving a UILocation to multiple raw script locations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

Issue 2857453002: DevTools: support resolving a UILocation to multiple raw script locations (Closed)

Patch Set: get rid of uniqueScriptId() Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/SourceFormatter.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js b/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

index e0158940f93897899c8c283d7f1fbf68065990e7..ad6d4800e508d06533e5ff94ff308e65d7bcb921 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

@@ -251,12 +251,12 @@ Sources.SourceMapNamesResolver.resolveExpression = function(

Sources.SourceMapNamesResolver._resolveExpression = function(

uiSourceCode, lineNumber, startColumnNumber, endColumnNumber) {

- var rawLocation =

- Bindings.debuggerWorkspaceBinding.uiLocationToRawLocation(uiSourceCode, lineNumber, startColumnNumber);

- if (!rawLocation)

+ var rawLocations =

+ Bindings.debuggerWorkspaceBinding.uiLocationToRawLocations(uiSourceCode, lineNumber, startColumnNumber);

+ if (!rawLocations.length)

return Promise.resolve('');

- var script = rawLocation.script();

+ var script = rawLocations[0].script();

if (!script)

return Promise.resolve('');

var sourceMap = Bindings.debuggerWorkspaceBinding.sourceMapForScript(script);