Issue 2857313002: M59: Defer deletion in PrintWebViewHelper while handling IPC messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2857313002: M59: Defer deletion in PrintWebViewHelper while handling IPC messages. (Closed)

Created:
3 years, 7 months ago by Lei Zhang

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

M59: Defer deletion in PrintWebViewHelper while handling IPC messages. Also calculate modifiability only once in PrintPreviewContext. This does less repeated work, and prevents accessing frames after their deletion. BUG=707549 Review-Url: https://codereview.chromium.org/2849483002 Cr-Commit-Position: refs/heads/master@{#467810} (cherry picked from commit 9c0e322c8de168b121cd6ae8cba92cd3214e5b1f) Review-Url: https://codereview.chromium.org/2857313002 . Cr-Commit-Position: refs/branch-heads/3071@{#385} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b6b5a52b378f25b3d7c917c119c1da28c4c2900b

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -16 lines)			Patch
	M	components/printing/renderer/print_web_view_helper.h	View		5 chunks	+9 lines, -1 line	0 comments	Download
	M	components/printing/renderer/print_web_view_helper.cc	View		13 chunks	+25 lines, -15 lines	0 comments	Download

Total messages: 2 (1 generated)

Lei Zhang

3 years, 7 months ago (2017-05-03 22:54:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b6b5a52b378f25b3d7c917c119c1da28c4c2900b.