Defer deletion in PrintWebViewHelper while handling IPC messages.

Defer deletion in PrintWebViewHelper while handling IPC messages.

Also calculate modifiability only once in PrintPreviewContext.
This does less repeated work, and prevents accessing frames after
their deletion.

BUG=707549
Review-Url: https://codereview.chromium.org/2849483002
Cr-Commit-Position: refs/heads/master@{#467810}
Committed: https://chromium.googlesource.com/chromium/src/+/9c0e322c8de168b121cd6ae8cba92cd3214e5b1f

[Lei Zhang, 2017-04-27 08:11:19]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 08:11:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 09:00:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 09:00:10]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-04-27 18:31:35]

Description was changed from

==========
Defer deletion in PrintWebViewHelper while handling IPC messages.

Also calculate modifiability only once in PrintPreviewContext.

BUG=707549
==========

to

==========
Defer deletion in PrintWebViewHelper while handling IPC messages.

Also calculate modifiability only once in PrintPreviewContext.
This does less repeated work, and prevents accessing frames after
their deletion.

BUG=707549
==========

[Lei Zhang, 2017-04-27 18:31:35]

thestig@chromium.org changed reviewers:
+ lfg@chromium.org

[Lei Zhang, 2017-04-27 18:32:57]

This replaces https://crrev.com/435323 - sometimes RenderFrame deletion can be
triggered pretty deep in the stack, and it is too cumbersome to use the WeakPtr
trick to unwind all the way out.

[lfg, 2017-04-27 19:44:14]

lgtm with nit.

https://codereview.chromium.org/2849483002/diff/1/components/printing/rendere...
File components/printing/renderer/print_web_view_helper.h (right):

https://codereview.chromium.org/2849483002/diff/1/components/printing/rendere...
components/printing/renderer/print_web_view_helper.h:512: bool is_modifiable_;
This seems to be uninitialized in the constructor.

[Lei Zhang, 2017-04-27 20:31:24]

https://codereview.chromium.org/2849483002/diff/1/components/printing/rendere...
File components/printing/renderer/print_web_view_helper.h (right):

https://codereview.chromium.org/2849483002/diff/1/components/printing/rendere...
components/printing/renderer/print_web_view_helper.h:512: bool is_modifiable_;
On 2017/04/27 19:44:14, lfg wrote:
> This seems to be uninitialized in the constructor.

Right. It's not ever used until after one of the Init* methods get called. I'll
initialize since it's generally a good thing to do. I also added a DCHECK to
make sure we are not trying to access it when |state_| is UNINITIALIZED.

[Lei Zhang, 2017-04-27 20:31:39]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2017-04-27 20:31:40]

The patchset sent to the CQ was uploaded after l-g-t-m from lfg@chromium.org
Link to the patchset: https://codereview.chromium.org/2849483002/#ps20001
(title: "address comment")

[commit-bot: I haz the power, 2017-04-27 20:32:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 20:55:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 20:55:55]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Lei Zhang, 2017-04-27 21:01:00]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2017-04-27 21:01:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:45:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493326860162500,
"parent_rev": "92607542c7cfde619e78d1b29490b1e1a13bb2da", "commit_rev":
"9c0e322c8de168b121cd6ae8cba92cd3214e5b1f"}

[commit-bot: I haz the power, 2017-04-28 01:45:28]

Description was changed from

==========
Defer deletion in PrintWebViewHelper while handling IPC messages.

Also calculate modifiability only once in PrintPreviewContext.
This does less repeated work, and prevents accessing frames after
their deletion.

BUG=707549
==========

to

==========
Defer deletion in PrintWebViewHelper while handling IPC messages.

Also calculate modifiability only once in PrintPreviewContext.
This does less repeated work, and prevents accessing frames after
their deletion.

BUG=707549

Review-Url: https://codereview.chromium.org/2849483002
Cr-Commit-Position: refs/heads/master@{#467810}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c0e322c8de168b121cd6ae8cba9...
==========

[commit-bot: I haz the power, 2017-04-28 01:45:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9c0e322c8de168b121cd6ae8cba9...