[ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC.

[ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC.

Semi-automatic conversion of ios/chrome/browser/tabs/tab.mm
to ARC (Automatic Reference Counting).

Manual changes:
-   audit raw Objective-C pointers and mark them as __weak if
    needed (were all correctly annotated with weak comments);
-   convert base::scoped_nsobject<> & base::WeakNSObject<> to
    annotations for the compiler (e.g. __weak);
-   remove setter/getter for properties that can be synthesized;
-   remove [[... retain] autorelease] as the CRWWebController
    has been converted to ARC already and thus the object will
    be autorelease and the hack is no longer required.

BUG=None

Review-Url: https://codereview.chromium.org/2857133002
Cr-Commit-Position: refs/heads/master@{#470518}
Committed: https://chromium.googlesource.com/chromium/src/+/2b53772d6855f3bc314bff3cbc4ee9f4a7bedb87

[sdefresne, 2017-05-09 16:30:45]

Description was changed from

==========
[ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC.

Semi-automatic conversion of ios/chrome/browser/tabs/tab.mm
to ARC (Automatic Reference Counting).

Manual changes:
-   audit raw Objective-C pointers and mark them as __weak if
    needed (were all correctly annotated with weak comments);
-   convert base::scoped_nsobject<> & base::WeakNSObject<> to
    annotations for the compiler (e.g. __weak);
-   remove setter/getter for properties that can be synthesized;
-   remove [[... retain] autorelease] as the CRWWebController
    has been converted to ARC already and thus the object will
    be autorelease and the hack is no longer required.

BUG=None
==========

to

==========
[ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC.

Semi-automatic conversion of ios/chrome/browser/tabs/tab.mm
to ARC (Automatic Reference Counting).

Manual changes:
-   audit raw Objective-C pointers and mark them as __weak if
    needed (were all correctly annotated with weak comments);
-   convert base::scoped_nsobject<> & base::WeakNSObject<> to
    annotations for the compiler (e.g. __weak);
-   remove setter/getter for properties that can be synthesized;
-   remove [[... retain] autorelease] as the CRWWebController
    has been converted to ARC already and thus the object will
    be autorelease and the hack is no longer required.

BUG=None
==========

[sdefresne, 2017-05-09 16:30:45]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2017-05-09 16:32:58]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-05-09 16:33:00]

This is a reland of https://codereview.chromium.org/2859663002. There is no
change (except for rebasing the code) as the issue with CRWWebController was
fixed in a separate CL (https://codereview.chromium.org/2854943003).

Please take a look.

[commit-bot: I haz the power, 2017-05-09 16:33:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2017-05-09 17:03:52]

Rubberstamp LGTM if no code has changed

Can you link to the WebController fix?

[rohitrao (ping after 24h), 2017-05-09 17:04:17]

Nm, just saw the link, thanks!

[commit-bot: I haz the power, 2017-05-09 19:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 19:38:55]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-05-10 07:54:46]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-05-10 07:55:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 08:01:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494402886529940,
"parent_rev": "268490faabdd39308b8f6955408172f29e590bdd", "commit_rev":
"2b53772d6855f3bc314bff3cbc4ee9f4a7bedb87"}

[commit-bot: I haz the power, 2017-05-10 08:01:22]

Description was changed from

==========
[ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC.

Semi-automatic conversion of ios/chrome/browser/tabs/tab.mm
to ARC (Automatic Reference Counting).

Manual changes:
-   audit raw Objective-C pointers and mark them as __weak if
    needed (were all correctly annotated with weak comments);
-   convert base::scoped_nsobject<> & base::WeakNSObject<> to
    annotations for the compiler (e.g. __weak);
-   remove setter/getter for properties that can be synthesized;
-   remove [[... retain] autorelease] as the CRWWebController
    has been converted to ARC already and thus the object will
    be autorelease and the hack is no longer required.

BUG=None
==========

to

==========
[ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC.

Semi-automatic conversion of ios/chrome/browser/tabs/tab.mm
to ARC (Automatic Reference Counting).

Manual changes:
-   audit raw Objective-C pointers and mark them as __weak if
    needed (were all correctly annotated with weak comments);
-   convert base::scoped_nsobject<> & base::WeakNSObject<> to
    annotations for the compiler (e.g. __weak);
-   remove setter/getter for properties that can be synthesized;
-   remove [[... retain] autorelease] as the CRWWebController
    has been converted to ARC already and thus the object will
    be autorelease and the hack is no longer required.

BUG=None

Review-Url: https://codereview.chromium.org/2857133002
Cr-Commit-Position: refs/heads/master@{#470518}
Committed:
https://chromium.googlesource.com/chromium/src/+/2b53772d6855f3bc314bff3cbc4e...
==========

[commit-bot: I haz the power, 2017-05-10 08:01:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b53772d6855f3bc314bff3cbc4e...