Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2859663002: Revert of [ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC. (Closed)

Created:
3 years, 7 months ago by michaeldo
Modified:
3 years, 7 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2846233002/ ) Reason for revert: causes failure of ios_chrome_ui_egtests on ipad air 2 ios 10. Ref: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/27116 Original issue's description: > [ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC. > > Semi-automatic conversion of ios/chrome/browser/tabs/tab.mm > to ARC (Automatic Reference Counting). > > Manual changes: > - audit raw Objective-C pointers and mark them as __weak if > needed (were all correctly annotated with weak comments); > - convert base::scoped_nsobject<> & base::WeakNSObject<> to > annotations for the compiler (e.g. __weak); > - remove setter/getter for properties that can be synthesized; > - remove [[... retain] autorelease] as the CRWWebController > has been converted to ARC already and thus the object will > be autorelease and the hack is no longer required. > > BUG=None > > Review-Url: https://codereview.chromium.org/2846233002 > Cr-Commit-Position: refs/heads/master@{#468660} > Committed: https://chromium.googlesource.com/chromium/src/+/376186504c93feac078435f1620005d15609974f TBR=stkhapugin@chromium.org,rohitrao@chromium.org,sdefresne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2859663002 Cr-Commit-Position: refs/heads/master@{#468777} Committed: https://chromium.googlesource.com/chromium/src/+/d8fea1f6efe2eb10d4b1f1c41a5cf62fa2dfc5d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -304 lines) Patch
M ios/chrome/browser/tabs/BUILD.gn View 3 chunks +5 lines, -52 lines 0 comments Download
M ios/chrome/browser/tabs/tab.h View 2 chunks +9 lines, -9 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 44 chunks +332 lines, -243 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
michaeldo
Created Revert of [ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC.
3 years, 7 months ago (2017-05-02 21:22:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859663002/1
3 years, 7 months ago (2017-05-02 21:23:29 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 21:25:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8fea1f6efe2eb10d4b1f1c41a5c...

Powered by Google App Engine
This is Rietveld 408576698