DescriptionRevert of [ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC. (patchset #3 id:40001 of https://codereview.chromium.org/2846233002/ )
Reason for revert:
causes failure of ios_chrome_ui_egtests on ipad air 2 ios 10.
Ref: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/27116
Original issue's description:
> [ios] ARCMigrate ios/chrome/browser/tabs/tab.mm to ARC.
>
> Semi-automatic conversion of ios/chrome/browser/tabs/tab.mm
> to ARC (Automatic Reference Counting).
>
> Manual changes:
> - audit raw Objective-C pointers and mark them as __weak if
> needed (were all correctly annotated with weak comments);
> - convert base::scoped_nsobject<> & base::WeakNSObject<> to
> annotations for the compiler (e.g. __weak);
> - remove setter/getter for properties that can be synthesized;
> - remove [[... retain] autorelease] as the CRWWebController
> has been converted to ARC already and thus the object will
> be autorelease and the hack is no longer required.
>
> BUG=None
>
> Review-Url: https://codereview.chromium.org/2846233002
> Cr-Commit-Position: refs/heads/master@{#468660}
> Committed: https://chromium.googlesource.com/chromium/src/+/376186504c93feac078435f1620005d15609974f
TBR=stkhapugin@chromium.org,rohitrao@chromium.org,sdefresne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review-Url: https://codereview.chromium.org/2859663002
Cr-Commit-Position: refs/heads/master@{#468777}
Committed: https://chromium.googlesource.com/chromium/src/+/d8fea1f6efe2eb10d4b1f1c41a5cf62fa2dfc5d6
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|