Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2857103003: Revert of [Identity Service] Add service tests of IdentityManager (Closed)

Created:
3 years, 7 months ago by blundell
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Identity Service] Add service tests of IdentityManager (patchset #1 id:1 of https://codereview.chromium.org/2854083002/ ) Reason for revert: Causing compile failure, looks like race with CL that landed between bot runs and commit of this CL: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Builder%2F83130%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original issue's description: > [Identity Service] Add service tests of IdentityManager > > This CL adds service tests to test basic functionality of the implementation > of identity_manager.mojom. Note that if/as service tests of other > interfaces are added, the utility code that sets up the Identity Service > can and should be split out of this test into a base class. > > BUG=683120 > > Review-Url: https://codereview.chromium.org/2854083002 > Cr-Commit-Position: refs/heads/master@{#468921} > Committed: https://chromium.googlesource.com/chromium/src/+/1a4c6321d2ab77267160bfb0297411e43d0daaab TBR=rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=683120 Review-Url: https://codereview.chromium.org/2857103003 Cr-Commit-Position: refs/heads/master@{#468924} Committed: https://chromium.googlesource.com/chromium/src/+/821f3cd4f25889619c532261e2945cb426f03d4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -194 lines) Patch
M services/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M services/identity/BUILD.gn View 2 chunks +0 lines, -34 lines 0 comments Download
M services/identity/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D services/identity/identity_manager_unittest.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D services/identity/unittest_manifest.json View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
blundell
Created Revert of [Identity Service] Add service tests of IdentityManager
3 years, 7 months ago (2017-05-03 09:07:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857103003/1
3 years, 7 months ago (2017-05-03 09:08:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/821f3cd4f25889619c532261e2945cb426f03d4f
3 years, 7 months ago (2017-05-03 09:08:45 UTC) #6
msramek
3 years, 7 months ago (2017-05-03 09:09:50 UTC) #8
Message was sent while issue was closed.
Sheriff LGTM

Powered by Google App Engine
This is Rietveld 408576698