Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2854083002: [Identity Service] Add service tests of IdentityManager (Closed)

Created:
3 years, 7 months ago by blundell
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Identity Service] Add service tests of IdentityManager This CL adds service tests to test basic functionality of the implementation of identity_manager.mojom. Note that if/as service tests of other interfaces are added, the utility code that sets up the Identity Service can and should be split out of this test into a base class. BUG=683120 Review-Url: https://codereview.chromium.org/2854083002 Cr-Original-Commit-Position: refs/heads/master@{#468921} Committed: https://chromium.googlesource.com/chromium/src/+/1a4c6321d2ab77267160bfb0297411e43d0daaab Review-Url: https://codereview.chromium.org/2854083002 Cr-Commit-Position: refs/heads/master@{#468980} Committed: https://chromium.googlesource.com/chromium/src/+/1e21bd3a8b2257bf96283f1ab9a12f09e55b3acf

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix for elimination of InterfaceFactory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -0 lines) Patch
M services/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M services/identity/BUILD.gn View 2 chunks +34 lines, -0 lines 0 comments Download
M services/identity/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A services/identity/identity_manager_unittest.cc View 1 2 1 chunk +136 lines, -0 lines 0 comments Download
A services/identity/unittest_manifest.json View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
blundell
3 years, 7 months ago (2017-05-02 15:34:47 UTC) #6
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-02 16:26:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854083002/1
3 years, 7 months ago (2017-05-03 08:52:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1a4c6321d2ab77267160bfb0297411e43d0daaab
3 years, 7 months ago (2017-05-03 08:56:39 UTC) #12
blundell
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2857103003/ by blundell@chromium.org. ...
3 years, 7 months ago (2017-05-03 09:07:57 UTC) #13
findit-for-me
Findit (https://goo.gl/kROfz5) confirmed this CL at revision 468921 as the culprit for failures in the ...
3 years, 7 months ago (2017-05-03 09:16:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854083002/40001
3 years, 7 months ago (2017-05-03 14:19:03 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 15:26:10 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1e21bd3a8b2257bf96283f1ab9a1...

Powered by Google App Engine
This is Rietveld 408576698