Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2857073002: diagnose_bloat.py: update logging and general clean up. (Closed)

Created:
3 years, 7 months ago by estevenson
Modified:
3 years, 7 months ago
Reviewers:
agrieve
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

diagnose_bloat.py: update logging and general clean up. Changed the script to use the logging module where possible and added a --silent flag that hides gclient/ninja output. Also added stderr to Ninja output so that users can check why a build failed. Changed the branch restore function to use atexit so that the original branch will be restored if ctrl-c is pressed while another rev is checked out. BUG=695182 Review-Url: https://codereview.chromium.org/2857073002 Cr-Commit-Position: refs/heads/master@{#469043} Committed: https://chromium.googlesource.com/chromium/src/+/40a227b78d6fed53d06420553275557179546502

Patch Set 1 #

Patch Set 2 : diagnose_apk_bloat.py: more error messages. #

Patch Set 3 : --silent help, metadata and step string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -886 lines) Patch
M tools/binary_size/README.md View 2 chunks +10 lines, -9 lines 0 comments Download
D tools/binary_size/diagnose_apk_bloat.py View 1 chunk +0 lines, -779 lines 0 comments Download
A + tools/binary_size/diagnose_bloat.py View 1 2 20 chunks +110 lines, -98 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
estevenson
ptal!
3 years, 7 months ago (2017-05-03 17:44:18 UTC) #2
agrieve
On 2017/05/03 17:44:18, estevenson wrote: > ptal! lgtm
3 years, 7 months ago (2017-05-03 18:11:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2857073002/40001
3 years, 7 months ago (2017-05-03 18:22:32 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 18:39:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/40a227b78d6fed53d06420553275...

Powered by Google App Engine
This is Rietveld 408576698