Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tools/binary_size/README.md

Issue 2857073002: diagnose_bloat.py: update logging and general clean up. (Closed)
Patch Set: --silent help, metadata and step string Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/binary_size/diagnose_apk_bloat.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/README.md
diff --git a/tools/binary_size/README.md b/tools/binary_size/README.md
index a3af7e6b14011ce791aa4388225e264c13094f15..85bf49b9fdb6233d7dfad07ac793f1460ccca7e6 100644
--- a/tools/binary_size/README.md
+++ b/tools/binary_size/README.md
@@ -60,23 +60,24 @@ A convenience command equivalent to: `console before.size after.size --query='Pr
tools/binary_size/supersize diff before.size after.size --all
-# diagnose_apk_bloat.py
+# diagnose_bloat.py
-Determine the cause of binary size bloat for a patch.
+Determine the cause of binary size bloat between two commits. Works for Android
+and partially works for Linux (crbug/717550).
## Example Usage:
# Build and diff HEAD^ and HEAD.
- tools/binary_size/diagnose_apk_bloat.py HEAD
+ tools/binary_size/diagnose_bloat.py HEAD
# Diff OTHERREV and REV using downloaded build artifacts.
- tools/binary_size/diagnose_apk_bloat.py REV --reference-rev OTHERREV --cloud
+ tools/binary_size/diagnose_bloat.py REV --reference-rev OTHERREV --cloud
- # Build and diff contiguous revs in range OTHERREV..REV for src/v8.
- tools/binary_size/diagnose_apk_bloat.py REV --reference-rev OTHERREV --subrepo v8 --all
+ # Build and diff all contiguous revs in range OTHERREV..REV for src/v8.
+ tools/binary_size/diagnose_bloat.py REV --reference-rev OTHERREV --subrepo v8 --all
# Display detailed usage info (there are many options).
- tools/binary_size/diagnose_apk_bloat.py -h
+ tools/binary_size/diagnose_bloat.py -h
# Roadmap for Super Size:
@@ -109,7 +110,7 @@ Tracked in https://crbug.com/681694
1. Speed up some steps (like normalizing names) via multiprocessing.
1. Add dependency graph info, perhaps just on a per-file basis.
-# Roadmap for diagnose_apk_bloat.py:
-1. More `diagnose_apk_bloat.py` features:
+# Roadmap for diagnose_bloat.py:
+1. More `diagnose_bloat.py` features:
* Add more diff types (pak files, Java symbols).
« no previous file with comments | « no previous file | tools/binary_size/diagnose_apk_bloat.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698