Add support for the VS2017 built binaries.

Add support for the VS2017 built binaries.

There's 2 things that had to be fixed:
- There's a new flag value for the 32 bit offset fixups, we used to always see a flag value of 0 but it's now set to 0x2000 in the VS2017 binaries.
- Add a workaround for what seems to be a toolchain bug in VS2017, the PDB contain some invalid symbols, see https://developercommunity.visualstudio.com/content/problem/47386/invalid-symbols-when-using-rtti.html

With these 2 changes we fully support the VS2017 built binaries.

BUG=chromium:683729
Review-Url: https://codereview.chromium.org/2856933003
Committed: https://github.com/google/syzygy/commit/ab9b65e1fd6a1821f0169b2338dd096bc7075742

[Sébastien Marchand, 2017-05-02 18:08:03]

Patchset #1 (id:1) has been deleted

[Sébastien Marchand, 2017-05-02 18:11:55]

Patchset #1 (id:20001) has been deleted

[Sébastien Marchand, 2017-05-02 18:12:28]

sebmarchand@chromium.org changed reviewers:
+ chrisha@chromium.org

[Sébastien Marchand, 2017-05-02 18:12:29]

PTAL.

[chrisha, 2017-05-02 19:54:58]

Great, lgtm! Thanks for the detailed comment.

[Sébastien Marchand, 2017-05-02 20:01:59]

Description was changed from

==========
Add support for the VS2017 built binaries.

BUG=chromium:683729
==========

to

==========
Add support for the VS2017 built binaries.

There's 2 things that had to be fixed:
- There's a new flag value for the 32 bit offset fixups, we used to always see a
flag value of 0 but it's now set to 0x2000 in the VS2017 binaries.
- Add a workaround for what seems to be a toolchain bug in VS2017, the PDB
contain some invalid symbols, see
https://developercommunity.visualstudio.com/content/problem/47386/invalid-sym...

BUG=chromium:683729
==========

[Sébastien Marchand, 2017-05-02 20:03:04]

Thanks, committing. I've updated the CL description.

[Sébastien Marchand, 2017-05-02 20:03:32]

Description was changed from

==========
Add support for the VS2017 built binaries.

There's 2 things that had to be fixed:
- There's a new flag value for the 32 bit offset fixups, we used to always see a
flag value of 0 but it's now set to 0x2000 in the VS2017 binaries.
- Add a workaround for what seems to be a toolchain bug in VS2017, the PDB
contain some invalid symbols, see
https://developercommunity.visualstudio.com/content/problem/47386/invalid-sym...

BUG=chromium:683729
==========

to

==========
Add support for the VS2017 built binaries.

There's 2 things that had to be fixed:
- There's a new flag value for the 32 bit offset fixups, we used to always see a
flag value of 0 but it's now set to 0x2000 in the VS2017 binaries.
- Add a workaround for what seems to be a toolchain bug in VS2017, the PDB
contain some invalid symbols, see
https://developercommunity.visualstudio.com/content/problem/47386/invalid-sym...

With these 2 changes we fully support the VS2017 built binaries.

BUG=chromium:683729
==========

[Sébastien Marchand, 2017-05-02 20:58:03]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2017-05-02 20:58:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 21:35:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493758683956390,
"parent_rev": "5970d392dbf2d3746fe13212eea1dbc9af9cd46c", "commit_rev":
"ab9b65e1fd6a1821f0169b2338dd096bc7075742"}

[commit-bot: I haz the power, 2017-05-02 21:35:27]

Description was changed from

==========
Add support for the VS2017 built binaries.

There's 2 things that had to be fixed:
- There's a new flag value for the 32 bit offset fixups, we used to always see a
flag value of 0 but it's now set to 0x2000 in the VS2017 binaries.
- Add a workaround for what seems to be a toolchain bug in VS2017, the PDB
contain some invalid symbols, see
https://developercommunity.visualstudio.com/content/problem/47386/invalid-sym...

With these 2 changes we fully support the VS2017 built binaries.

BUG=chromium:683729
==========

to

==========
Add support for the VS2017 built binaries.

There's 2 things that had to be fixed:
- There's a new flag value for the 32 bit offset fixups, we used to always see a
flag value of 0 but it's now set to 0x2000 in the VS2017 binaries.
- Add a workaround for what seems to be a toolchain bug in VS2017, the PDB
contain some invalid symbols, see
https://developercommunity.visualstudio.com/content/problem/47386/invalid-sym...

With these 2 changes we fully support the VS2017 built binaries.

BUG=chromium:683729

Review-Url: https://codereview.chromium.org/2856933003
Committed:
https://github.com/google/syzygy/commit/ab9b65e1fd6a1821f0169b2338dd096bc7075742
==========

[commit-bot: I haz the power, 2017-05-02 21:35:28]

Committed patchset #1 (id:40001) as
https://github.com/google/syzygy/commit/ab9b65e1fd6a1821f0169b2338dd096bc7075742