Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: syzygy/pdb/pdb_data.cc

Issue 2856933003: Add support for the VS2017 built binaries. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « syzygy/pdb/pdb_data.h ('k') | syzygy/pe/decomposer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: syzygy/pdb/pdb_data.cc
diff --git a/syzygy/pdb/pdb_data.cc b/syzygy/pdb/pdb_data.cc
index e82535533e965698fa0902f978589cc82562f527..80fb655c9cf630f742ff744ad49b97e4668b9fcd 100644
--- a/syzygy/pdb/pdb_data.cc
+++ b/syzygy/pdb/pdb_data.cc
@@ -30,8 +30,7 @@ bool PdbFixup::ValidHeader() const {
case TYPE_OFFSET_32BIT:
case TYPE_OFFSET_8BIT: {
- // We've only ever seen offset fixups without flags.
- return flags == 0;
+ return (flags & ~FLAG_OFFSET_32BIT_VS2017) == 0;
}
default: {
« no previous file with comments | « syzygy/pdb/pdb_data.h ('k') | syzygy/pe/decomposer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698