Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 2856683003: Revert of Use trace wrapper in PopStateEvent (Closed)

Created:
3 years, 7 months ago by bashi
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use trace wrapper in PopStateEvent (patchset #1 id:1 of https://codereview.chromium.org/2850133002/ ) Reason for revert: Broke builds Original issue's description: > Don't store ScriptValue in PopStateEvent > > Use TraceWrapperV8Reference instead. This CL doesn't remove > custom getter of PopStateEvent.state as more work will be > needed to remove custom bindings. > > BUG=501866 > > Review-Url: https://codereview.chromium.org/2850133002 > Cr-Commit-Position: refs/heads/master@{#468565} > Committed: https://chromium.googlesource.com/chromium/src/+/77301cfe98de369b7d72659d4a95014f1d4dc4b6 TBR=haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=501866 Review-Url: https://codereview.chromium.org/2856683003 Cr-Commit-Position: refs/heads/master@{#468566} Committed: https://chromium.googlesource.com/chromium/src/+/1df4bbd0744720e49bcd98deb70753d4c1602205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -44 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/PopStateEvent.h View 3 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/events/PopStateEvent.cpp View 3 chunks +7 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/events/PopStateEvent.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
bashi
Created Revert of Use trace wrapper in PopStateEvent
3 years, 7 months ago (2017-05-02 05:22:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856683003/1
3 years, 7 months ago (2017-05-02 05:24:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1df4bbd0744720e49bcd98deb70753d4c1602205
3 years, 7 months ago (2017-05-02 05:26:15 UTC) #7
haraken
3 years, 7 months ago (2017-05-02 06:23:02 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698