Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: third_party/WebKit/Source/core/events/PopStateEvent.h

Issue 2856683003: Revert of Use trace wrapper in PopStateEvent (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/PopStateEvent.h
diff --git a/third_party/WebKit/Source/core/events/PopStateEvent.h b/third_party/WebKit/Source/core/events/PopStateEvent.h
index 0a81700156a5db5748b731c469df79a376f49173..22da42d1db4f2ef04758677a3f709ecffe668544 100644
--- a/third_party/WebKit/Source/core/events/PopStateEvent.h
+++ b/third_party/WebKit/Source/core/events/PopStateEvent.h
@@ -27,8 +27,6 @@
#ifndef PopStateEvent_h
#define PopStateEvent_h
-#include "bindings/core/v8/DOMWrapperWorld.h"
-#include "bindings/core/v8/TraceWrapperV8Reference.h"
#include "core/events/Event.h"
#include "core/events/PopStateEventInit.h"
#include "platform/heap/Handle.h"
@@ -45,11 +43,9 @@
~PopStateEvent() override;
static PopStateEvent* Create();
static PopStateEvent* Create(PassRefPtr<SerializedScriptValue>, History*);
- static PopStateEvent* Create(ScriptState*,
- const AtomicString&,
- const PopStateEventInit&);
+ static PopStateEvent* Create(const AtomicString&, const PopStateEventInit&);
- ScriptValue state(ScriptState*) const;
+ ScriptValue state() const { return state_; }
SerializedScriptValue* SerializedState() const {
return serialized_state_.Get();
}
@@ -63,16 +59,13 @@
DECLARE_VIRTUAL_TRACE();
- DECLARE_VIRTUAL_TRACE_WRAPPERS();
-
private:
PopStateEvent();
- PopStateEvent(ScriptState*, const AtomicString&, const PopStateEventInit&);
+ PopStateEvent(const AtomicString&, const PopStateEventInit&);
PopStateEvent(PassRefPtr<SerializedScriptValue>, History*);
RefPtr<SerializedScriptValue> serialized_state_;
- RefPtr<DOMWrapperWorld> world_;
- TraceWrapperV8Reference<v8::Value> state_;
+ ScriptValue state_;
Member<History> history_;
};

Powered by Google App Engine
This is Rietveld 408576698