Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2856623002: Adding static asserts to LatencyInfo struct traits. (Closed)

Created:
3 years, 7 months ago by mfomitchev
Modified:
3 years, 7 months ago
Reviewers:
Tom Sepez, tdresser
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding static asserts to LatencyInfo struct traits. Asserts ensure that the number of items in corresponding ui and mojom enums matches each other. BUG=NONE Review-Url: https://codereview.chromium.org/2856623002 Cr-Commit-Position: refs/heads/master@{#468408} Committed: https://chromium.googlesource.com/chromium/src/+/648dc8df32f3eed0b0149b08148cd8a9b3e1c83c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ui/latency/mojo/latency_info_struct_traits.h View 1 chunk +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
mfomitchev
PTAL
3 years, 7 months ago (2017-05-01 18:33:10 UTC) #3
tdresser
LGTM
3 years, 7 months ago (2017-05-01 18:34:35 UTC) #4
Tom Sepez
Good Idea. LGTM.
3 years, 7 months ago (2017-05-01 18:35:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856623002/1
3 years, 7 months ago (2017-05-01 18:53:09 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 21:09:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/648dc8df32f3eed0b0149b08148c...

Powered by Google App Engine
This is Rietveld 408576698