Adding source_event_type to LatencyInfo mojom

Adding source_event_type to LatencyInfo mojom

This is needed for proper latency reporting in Mus and in fact also in classic
Chrome now that renderers submit compositor frames over Mojo.

BUG=686865
Review-Url: https://codereview.chromium.org/2847553003
Cr-Commit-Position: refs/heads/master@{#468372}
Committed: https://chromium.googlesource.com/chromium/src/+/859478de176cb190f39398aba66157315e66fd17

[mfomitchev, 2017-04-27 02:33:30]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 02:34:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2017-04-27 02:47:41]

The CQ bit was checked by mfomitchev@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 02:48:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 04:25:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 04:26:00]

Dry run: This issue passed the CQ dry run.

[mfomitchev, 2017-04-27 13:16:11]

mfomitchev@chromium.org changed reviewers:
+ tdresser@chromium.org, tsepez@chromium.org

[mfomitchev, 2017-04-27 13:16:11]

PTAL

[tdresser, 2017-04-27 14:39:27]

LGTM % concerns regarding getting out of sync.

https://codereview.chromium.org/2847553003/diff/20001/ui/latency/mojo/latency...
File ui/latency/mojo/latency_info.mojom (right):

https://codereview.chromium.org/2847553003/diff/20001/ui/latency/mojo/latency...
ui/latency/mojo/latency_info.mojom:83: SOURCE_EVENT_TYPE_LAST = OTHER,
Is there some assertion we can add to reduce the risk of these (and the
LatencyComponentType) getting out of sync with latency_info.h?

[Tom Sepez, 2017-04-27 16:12:11]

lgtm

[mfomitchev, 2017-04-27 22:06:28]

https://codereview.chromium.org/2847553003/diff/20001/ui/latency/mojo/latency...
File ui/latency/mojo/latency_info.mojom (right):

https://codereview.chromium.org/2847553003/diff/20001/ui/latency/mojo/latency...
ui/latency/mojo/latency_info.mojom:83: SOURCE_EVENT_TYPE_LAST = OTHER,
On 2017/04/27 14:39:27, tdresser wrote:
> Is there some assertion we can add to reduce the risk of these (and the
> LatencyComponentType) getting out of sync with latency_info.h?

What if we add an assert for ui::mojom::LATENCY_COMPONENT_TYPE_LAST matching
ui::LATENCY_COMPONENT_TYPE_LAST and a similar one for SOURCE_EVENT_TYPE_LAST in
latency_info_struct_traits.h?

tsepez@: Interested in your thoughts as well. Are we doing anything like this
elsewhere?

[Fady Samuel, 2017-04-27 22:49:25]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-04-27 22:49:25]

https://codereview.chromium.org/2847553003/diff/20001/ui/latency/mojo/latency...
File ui/latency/mojo/latency_info.mojom (right):

https://codereview.chromium.org/2847553003/diff/20001/ui/latency/mojo/latency...
ui/latency/mojo/latency_info.mojom:83: SOURCE_EVENT_TYPE_LAST = OTHER,
On 2017/04/27 14:39:27, tdresser wrote:
> Is there some assertion we can add to reduce the risk of these (and the
> LatencyComponentType) getting out of sync with latency_info.h?

We deal with this problem in cc via SetAll/SetNew usage. Basically, you can't
much around with things directly

[tdresser, 2017-04-28 13:20:05]

On 2017/04/27 22:49:25, Fady Samuel wrote:
>
https://codereview.chromium.org/2847553003/diff/20001/ui/latency/mojo/latency...
> File ui/latency/mojo/latency_info.mojom (right):
> 
>
https://codereview.chromium.org/2847553003/diff/20001/ui/latency/mojo/latency...
> ui/latency/mojo/latency_info.mojom:83: SOURCE_EVENT_TYPE_LAST = OTHER,
> On 2017/04/27 14:39:27, tdresser wrote:
> > Is there some assertion we can add to reduce the risk of these (and the
> > LatencyComponentType) getting out of sync with latency_info.h?
> 
> We deal with this problem in cc via SetAll/SetNew usage. Basically, you can't
> much around with things directly

Mikhail - those asserts SGTM!

[mfomitchev, 2017-05-01 17:43:47]

The CQ bit was checked by mfomitchev@chromium.org

[commit-bot: I haz the power, 2017-05-01 17:44:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 18:50:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493660627876640,
"parent_rev": "46577d66405c2b6d3fd7e490733a24b3c59a7a3c", "commit_rev":
"859478de176cb190f39398aba66157315e66fd17"}

[commit-bot: I haz the power, 2017-05-01 18:50:53]

Description was changed from

==========
Adding source_event_type to LatencyInfo mojom

This is needed for proper latency reporting in Mus and in fact also in classic
Chrome now that renderers submit compositor frames over Mojo.

BUG=686865
==========

to

==========
Adding source_event_type to LatencyInfo mojom

This is needed for proper latency reporting in Mus and in fact also in classic
Chrome now that renderers submit compositor frames over Mojo.

BUG=686865

Review-Url: https://codereview.chromium.org/2847553003
Cr-Commit-Position: refs/heads/master@{#468372}
Committed:
https://chromium.googlesource.com/chromium/src/+/859478de176cb190f39398aba661...
==========

[commit-bot: I haz the power, 2017-05-01 18:50:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/859478de176cb190f39398aba661...