Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1665)

Issue 2856573003: Fix the broken XML parser due to version mismatch. (Closed)

Created:
3 years, 7 months ago by Sorin Jianu
Modified:
3 years, 7 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the broken XML parser due to version mismatch. BUG=687231 Review-Url: https://codereview.chromium.org/2856573003 Cr-Commit-Position: refs/heads/master@{#468465} Committed: https://chromium.googlesource.com/chromium/src/+/3985280845a1a6b0cac775e1fe2be396f0c42bce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -47 lines) Patch
M components/test/data/update_client/updatecheck_diff_reply_1.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/test/data/update_client/updatecheck_diff_reply_2.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M components/test/data/update_client/updatecheck_diff_reply_3.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/test/data/update_client/updatecheck_reply_1.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/test/data/update_client/updatecheck_reply_2.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M components/test/data/update_client/updatecheck_reply_3.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/test/data/update_client/updatecheck_reply_4.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/test/data/update_client/updatecheck_reply_noupdate.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/update_client/update_client_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M components/update_client/update_response.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/update_client/update_response.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/update_client/update_response_unittest.cc View 18 chunks +18 lines, -18 lines 0 comments Download
M components/update_client/utils.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Sorin Jianu
PTAL!
3 years, 7 months ago (2017-05-01 19:00:37 UTC) #4
waffles
lgtm
3 years, 7 months ago (2017-05-01 19:03:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856573003/1
3 years, 7 months ago (2017-05-01 19:04:59 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 22:46:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3985280845a1a6b0cac775e1fe2b...

Powered by Google App Engine
This is Rietveld 408576698