Fix the broken XML parser due to version mismatch.

components/update_client/update_response_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/update_client/update_response.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace update_client {
 
 const char* kValidXml =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='12345'>"
     "   <updatecheck status='ok'>"
     "     <urls>"
     "       <url codebase='http://example.com/'/>"
     "       <url codebasediff='http://diff.example.com/'/>"
     "     </urls>"
     "     <manifest version='1.2.3.4' prodversionmin='2.0.143.0'>"
     "       <packages>"
     "         <package name='extension_1_2_3_4.crx'/>"
     "       </packages>"
     "     </manifest>"
     "   </updatecheck>"
     " </app>"
     "</response>";
 
 const char* valid_xml_with_hash =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='12345'>"
     "   <updatecheck status='ok'>"
     "     <urls>"
     "       <url codebase='http://example.com/'/>"
     "     </urls>"
     "     <manifest version='1.2.3.4' prodversionmin='2.0.143.0'>"
     "       <packages>"
     "         <package name='extension_1_2_3_4.crx' hash_sha256='1234'"
     "             hashdiff_sha256='5678'/>"
     "       </packages>"
     "     </manifest>"
     "   </updatecheck>"
     " </app>"
     "</response>";
 
 const char* valid_xml_with_invalid_sizes =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='12345'>"
     "   <updatecheck status='ok'>"
     "     <urls>"
     "       <url codebase='http://example.com/'/>"
     "     </urls>"
     "     <manifest version='1.2.3.4' prodversionmin='2.0.143.0'>"
     "       <packages>"
     "         <package name='1' size='1234'/>"
     "         <package name='2' size='-1234'/>"
     "         <package name='3' />"
     "         <package name='4' size='-a'/>"
     "         <package name='5' size='-123467890123456789'/>"
     "         <package name='6' size='123467890123456789'/>"
     "       </packages>"
     "     </manifest>"
     "   </updatecheck>"
     " </app>"
     "</response>";
 
 const char* kInvalidValidXmlMissingCodebase =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='12345'>"
     "   <updatecheck status='ok'>"
     "     <urls>"
     "       <url codebasediff='http://diff.example.com/'/>"
     "     </urls>"
     "     <manifest version='1.2.3.4' prodversionmin='2.0.143.0'>"
     "       <packages>"
     "         <package namediff='extension_1_2_3_4.crx'/>"
     "       </packages>"
     "     </manifest>"
     "   </updatecheck>"
     " </app>"
     "</response>";
 
 const char* kInvalidValidXmlMissingManifest =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='12345'>"
     "   <updatecheck status='ok'>"
     "     <urls>"
     "       <url codebase='http://example.com/'/>"
     "     </urls>"
     "   </updatecheck>"
     " </app>"
     "</response>";
 
 const char* kMissingAppId =
     "<?xml version='1.0'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app>"
     "  <updatecheck codebase='http://example.com/extension_1.2.3.4.crx'"
     "               version='1.2.3.4'/>"
     " </app>"
     "</response>";
 
 const char* kInvalidCodebase =
     "<?xml version='1.0'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='12345' status='ok'>"
     "  <updatecheck codebase='example.com/extension_1.2.3.4.crx'"
     "               version='1.2.3.4'/>"
     " </app>"
     "</response>";
 
 const char* kMissingVersion =
     "<?xml version='1.0'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='12345' status='ok'>"
     "  <updatecheck codebase='http://example.com/extension_1.2.3.4.crx'/>"
     " </app>"
     "</response>";
 
 const char* kInvalidVersion =
     "<?xml version='1.0'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='12345' status='ok'>"
     "  <updatecheck codebase='http://example.com/extension_1.2.3.4.crx' "
     "               version='1.2.3.a'/>"
     " </app>"
     "</response>";
 
 // The v3 version of the protocol is not using namespaces. However, the parser
 // must be able to parse responses that include namespaces.
 const char* kUsesNamespacePrefix =
     "<?xml version='1.0' encoding='UTF-8'?>"
     "<g:response xmlns:g='http://www.google.com/update2/response' "
-    "protocol='3.0'>"
+    "protocol='3.1'>"
     " <g:app appid='12345'>"
     "   <g:updatecheck status='ok'>"
     "     <g:urls>"
     "       <g:url codebase='http://example.com/'/>"
     "     </g:urls>"
     "     <g:manifest version='1.2.3.4' prodversionmin='2.0.143.0'>"
     "       <g:packages>"
     "         <g:package name='extension_1_2_3_4.crx'/>"
     "       </g:packages>"
     "     </g:manifest>"
     "   </g:updatecheck>"
     " </g:app>"
     "</g:response>";
 
 // Includes unrelated <app> tags from other xml namespaces - this should
 // not cause problems.
 const char* kSimilarTagnames =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response xmlns:a='http://a' protocol='3.0'>"
+    "<response xmlns:a='http://a' protocol='3.1'>"
     " <a:app appid='12345'>"
     "   <updatecheck status='ok'>"
     "     <urls>"
     "       <url codebase='http://example.com/'/>"
     "     </urls>"
     "     <manifest version='1.2.3.4' prodversionmin='2.0.143.0'>"
     "       <packages>"
     "         <package name='extension_1_2_3_4.crx'/>"
     "       </packages>"
     "     </manifest>"
     "   </updatecheck>"
     " </a:app>"
     " <b:app appid='xyz' xmlns:b='http://b'>"
     "   <updatecheck status='noupdate'/>"
     " </b:app>"
     "</response>";
 
 // Includes a <daystart> tag.
 const char* kWithDaystart =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <daystart elapsed_seconds='456'/>"
     " <app appid='12345'>"
     "   <updatecheck status='ok'>"
     "     <urls>"
     "       <url codebase='http://example.com/'/>"
     "     </urls>"
     "     <manifest version='1.2.3.4' prodversionmin='2.0.143.0'>"
     "       <packages>"
     "         <package name='extension_1_2_3_4.crx'/>"
     "       </packages>"
     "     </manifest>"
     "   </updatecheck>"
     " </app>"
     "</response>";
 
 // Indicates no updates available - this should not be a parse error.
 const char* kNoUpdate =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='12345'>"
     "  <updatecheck status='noupdate'/>"
     " </app>"
     "</response>";
 
 // Includes two <app> tags, one with an error.
 const char* kTwoAppsOneError =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='aaaaaaaa' status='error-unknownApplication'>"
     "  <updatecheck status='error-internal'/>"
     " </app>"
     " <app appid='bbbbbbbb'>"
     "   <updatecheck status='ok'>"
     "     <urls>"
     "       <url codebase='http://example.com/'/>"
     "     </urls>"
     "     <manifest version='1.2.3.4' prodversionmin='2.0.143.0'>"
     "       <packages>"
     "         <package name='extension_1_2_3_4.crx'/>"
     "       </packages>"
     "     </manifest>"
     "   </updatecheck>"
     " </app>"
     "</response>";
 
 // Includes two <app> tags, both of which set the cohort.
 const char* kTwoAppsSetCohort =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='aaaaaaaa' cohort='1:2q3/'>"
     "  <updatecheck status='noupdate'/>"
     " </app>"
     " <app appid='bbbbbbbb' cohort='1:33z@0.33' cohortname='cname'>"
     "   <updatecheck status='ok'>"
     "     <urls>"
     "       <url codebase='http://example.com/'/>"
     "     </urls>"
     "     <manifest version='1.2.3.4' prodversionmin='2.0.143.0'>"
     "       <packages>"
     "         <package name='extension_1_2_3_4.crx'/>"
     "       </packages>"
     "     </manifest>"
     "   </updatecheck>"
     " </app>"
     "</response>";
 
 // Includes a run action for an update check with status='ok'.
 const char* kUpdateCheckStatusOkWithRunAction =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='12345'>"
     "   <updatecheck status='ok'>"
     "     <urls>"
     "       <url codebase='http://example.com/'/>"
     "       <url codebasediff='http://diff.example.com/'/>"
     "     </urls>"
     "     <manifest version='1.2.3.4' prodversionmin='2.0.143.0'>"
     "       <packages>"
     "         <package name='extension_1_2_3_4.crx'/>"
     "       </packages>"
     "     </manifest>"
     "     <actions>"
     "       <action run='this'/>"
     "     </actions>"
     "   </updatecheck>"
     " </app>"
     "</response>";
 
 // Includes a run action for an update check with status='noupdate'.
 const char* kUpdateCheckStatusNoUpdateWithRunAction =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='12345'>"
     "   <updatecheck status='noupdate'>"
     "     <actions>"
     "       <action run='this'/>"
     "     </actions>"
     "   </updatecheck>"
     " </app>"
     "</response>";
 
 // Includes a run action for an update check with status='error'.
 const char* kUpdateCheckStatusErrorWithRunAction =
     "<?xml version='1.0' encoding='UTF-8'?>"
-    "<response protocol='3.0'>"
+    "<response protocol='3.1'>"
     " <app appid='12345' status='ok'>"
     "  <updatecheck status='error-osnotsupported'>"
     "     <actions>"
     "       <action run='this'/>"
     "     </actions>"
     "   </updatecheck>"
     " </app>"
     "</response>";
 
 TEST(ComponentUpdaterUpdateResponseTest, TestParser) {
@@ skipping 132 matching lines @@
   EXPECT_STREQ("noupdate", firstResult->status.c_str());
   EXPECT_EQ(firstResult->extension_id, "12345");
   EXPECT_STREQ("this", firstResult->action_run.c_str());
 
   EXPECT_TRUE(parser.Parse(kUpdateCheckStatusErrorWithRunAction));
   EXPECT_FALSE(parser.errors().empty());
   EXPECT_TRUE(parser.results().list.empty());
 }
 
 }  // namespace update_client