Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issue 2856563002: Check entry exists in DeviceDataManagerX11::UpdateDeviceList(). (Closed)

Created:
3 years, 7 months ago by kylechar
Modified:
3 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Check entry exists in DeviceDataManagerX11::UpdateDeviceList(). There is a crash in DeviceDataManagerX11::UpdateDeviceList() that could occur if there is no valuator information for the deviceid. BUG=716422 Review-Url: https://codereview.chromium.org/2856563002 Cr-Commit-Position: refs/heads/master@{#468340} Committed: https://chromium.googlesource.com/chromium/src/+/76aca77545743215506fc9e9eb0c1299e89553ae

Patch Set 1 #

Patch Set 2 : Just fix bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/events/devices/x11/device_data_manager_x11.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
kylechar
3 years, 7 months ago (2017-05-01 15:02:00 UTC) #2
sadrul
lgtm
3 years, 7 months ago (2017-05-01 15:42:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856563002/20001
3 years, 7 months ago (2017-05-01 15:43:34 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 17:17:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/76aca77545743215506fc9e9eb0c...

Powered by Google App Engine
This is Rietveld 408576698