Merge DeviceDataManagerX11 valuator information.

Merge DeviceDataManagerX11 valuator information.

Merge the three arrays that contain the valuator number, min and max
into one array that contains a struct. These three values are related.

BUG=716422
Review-Url: https://codereview.chromium.org/2848253002
Cr-Commit-Position: refs/heads/master@{#468347}
Committed: https://chromium.googlesource.com/chromium/src/+/0d89774170b1e7f1bdf62f355c64edb654c1010e

[kylechar, 2017-05-01 15:02:06]

kylechar@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2017-05-01 16:03:57]

Thanks! lgtm

https://codereview.chromium.org/2848253002/diff/1/ui/events/devices/x11/devic...
File ui/events/devices/x11/device_data_manager_x11.cc (right):

https://codereview.chromium.org/2848253002/diff/1/ui/events/devices/x11/devic...
ui/events/devices/x11/device_data_manager_x11.cc:749:
valuator_lookup_[deviceid][j].number = valuator_count_[deviceid];
Maybe something like:
  ValuatorInfo* info = &valuator_look_[device_id][j];
  info->... = ...

and so on

https://codereview.chromium.org/2848253002/diff/1/ui/events/devices/x11/devic...
ui/events/devices/x11/device_data_manager_x11.cc:773:
valuator_lookup_[deviceid][data_type].max = valuator_class_info->max;
ditto

[kylechar, 2017-05-01 16:10:17]

https://codereview.chromium.org/2848253002/diff/1/ui/events/devices/x11/devic...
File ui/events/devices/x11/device_data_manager_x11.cc (right):

https://codereview.chromium.org/2848253002/diff/1/ui/events/devices/x11/devic...
ui/events/devices/x11/device_data_manager_x11.cc:749:
valuator_lookup_[deviceid][j].number = valuator_count_[deviceid];
On 2017/05/01 16:03:56, sadrul wrote:
> Maybe something like:
>   ValuatorInfo* info = &valuator_look_[device_id][j];
>   info->... = ...
> 
> and so on

Done with "auto& valuator_info = ...".

https://codereview.chromium.org/2848253002/diff/1/ui/events/devices/x11/devic...
ui/events/devices/x11/device_data_manager_x11.cc:773:
valuator_lookup_[deviceid][data_type].max = valuator_class_info->max;
On 2017/05/01 16:03:56, sadrul wrote:
> ditto

Done.

[kylechar, 2017-05-01 16:10:55]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 16:11:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 17:15:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 17:15:23]

Dry run: This issue passed the CQ dry run.

[kylechar, 2017-05-01 17:28:44]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-05-01 17:28:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2848253002/#ps20001
(title: "Fix.")

[commit-bot: I haz the power, 2017-05-01 17:29:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 17:36:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493659724472390,
"parent_rev": "41a37b9e82b9f33982f6add34906fed081303ca9", "commit_rev":
"0d89774170b1e7f1bdf62f355c64edb654c1010e"}

[commit-bot: I haz the power, 2017-05-01 17:36:50]

Description was changed from

==========
Merge DeviceDataManagerX11 valuator information.

Merge the three arrays that contain the valuator number, min and max
into one array that contains a struct. These three values are related.

BUG=716422
==========

to

==========
Merge DeviceDataManagerX11 valuator information.

Merge the three arrays that contain the valuator number, min and max
into one array that contains a struct. These three values are related.

BUG=716422

Review-Url: https://codereview.chromium.org/2848253002
Cr-Commit-Position: refs/heads/master@{#468347}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d89774170b1e7f1bdf62f355c64...
==========

[commit-bot: I haz the power, 2017-05-01 17:36:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d89774170b1e7f1bdf62f355c64...