Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2856523003: Reland of Disable flaky ExperimentalAppWindowApiTest.SetIcon (Closed)

Created:
3 years, 7 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 7 months ago
Reviewers:
benwells
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable flaky ExperimentalAppWindowApiTest.SetIcon (patchset #1 id:1 of https://codereview.chromium.org/2855563002/ ) Reason for revert: Build failure causing original revert seems to have been a flake. Original issue's description: > Revert of Disable flaky ExperimentalAppWindowApiTest.SetIcon (patchset #1 id:1 of https://codereview.chromium.org/2849073003/ ) > > Reason for revert: > Speculatively reverting due to build failure on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/26841 > > Original issue's description: > > Disable flaky ExperimentalAppWindowApiTest.SetIcon > > > > TBR=benwells@chromium.org > > BUG=716726 > > > > Review-Url: https://codereview.chromium.org/2849073003 > > Cr-Commit-Position: refs/heads/master@{#468285} > > Committed: https://chromium.googlesource.com/chromium/src/+/78552aab8b749f33cd8176a977bdff4fa7d5de50 > > TBR=benwells@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=716726 > > Review-Url: https://codereview.chromium.org/2855563002 > Cr-Commit-Position: refs/heads/master@{#468289} > Committed: https://chromium.googlesource.com/chromium/src/+/dfe887bdaf1ea9fb0b3a7566dbdde620c869d42c TBR=benwells@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=716726 Review-Url: https://codereview.chromium.org/2856523003 Cr-Commit-Position: refs/heads/master@{#468303} Committed: https://chromium.googlesource.com/chromium/src/+/1853a2e624d2e0f62729eab082c8a1deae1a16e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M extensions/browser/api/app_window/app_window_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
suzyh_UTC10 (ex-contributor)
Created Reland of Disable flaky ExperimentalAppWindowApiTest.SetIcon
3 years, 7 months ago (2017-05-01 07:09:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856523003/1
3 years, 7 months ago (2017-05-01 07:09:27 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 07:09:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1853a2e624d2e0f62729eab082c8...

Powered by Google App Engine
This is Rietveld 408576698