Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2849073003: Disable flaky ExperimentalAppWindowApiTest.SetIcon (Closed)

Created:
3 years, 7 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 7 months ago
Reviewers:
benwells
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky ExperimentalAppWindowApiTest.SetIcon TBR=benwells@chromium.org BUG=716726 Review-Url: https://codereview.chromium.org/2849073003 Cr-Commit-Position: refs/heads/master@{#468285} Committed: https://chromium.googlesource.com/chromium/src/+/78552aab8b749f33cd8176a977bdff4fa7d5de50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M extensions/browser/api/app_window/app_window_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
suzyh_UTC10 (ex-contributor)
3 years, 7 months ago (2017-05-01 04:19:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849073003/1
3 years, 7 months ago (2017-05-01 04:19:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/78552aab8b749f33cd8176a977bdff4fa7d5de50
3 years, 7 months ago (2017-05-01 05:03:21 UTC) #6
suzyh_UTC10 (ex-contributor)
3 years, 7 months ago (2017-05-01 05:29:29 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2855563002/ by suzyh@chromium.org.

The reason for reverting is: Speculatively reverting due to build failure on Mac
https://build.chromium.org/p/chromium/builders/Mac/builds/26841.

Powered by Google App Engine
This is Rietveld 408576698