Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2856523002: Reland of CSS Motion Path: delete implementation of motion-offset property (Closed)

Created:
3 years, 7 months ago by Eric Willigers
Modified:
3 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-frames_chromium.org, chromium-reviews, dglazkov+blink, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of CSS Motion Path: delete implementation of motion-offset property (patchset #1 id:1 of https://codereview.chromium.org/2856513002/ ) Reason for revert: https://codereview.chromium.org/2841863005 was extremely unlikely to be the root cause of Mac-specific failures. Original issue's description: > Revert of CSS Motion Path: delete implementation of motion-offset property (patchset #2 id:40001 of https://codereview.chromium.org/2841863005/ ) > > Reason for revert: > Speculatively reverting due to build failure on Mac https://build.chromium.org/p/chromium/builders/Mac/builds/26841 > > Original issue's description: > > CSS Motion Path: delete implementation of motion-offset property > > > > The 'motion-offset' property has been replaced by 'offset-distance'. > > > > 'motion-offset' is among the properties disabled in M58. > > > > Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1MbAgAJ > > > > BUG=711937 > > > > Review-Url: https://codereview.chromium.org/2841863005 > > Cr-Commit-Position: refs/heads/master@{#468287} > > Committed: https://chromium.googlesource.com/chromium/src/+/612ac411762985a97166c4144ff0d049716a80db > > TBR=bugsnash@chromium.org,meade@chromium.org,ericwilligers@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=711937 > > Review-Url: https://codereview.chromium.org/2856513002 > Cr-Commit-Position: refs/heads/master@{#468291} > Committed: https://chromium.googlesource.com/chromium/src/+/d62951aca80fa961d7feb4c05fe62b0893f59bfd TBR=bugsnash@chromium.org,meade@chromium.org,suzyh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=711937 Review-Url: https://codereview.chromium.org/2856523002 Cr-Commit-Position: refs/heads/master@{#468301} Committed: https://chromium.googlesource.com/chromium/src/+/71f3bd1682b75efac412a7431adae78afb8a903b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -314 lines) Patch
D third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html View 1 chunk +0 lines, -39 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/animations-responsive-offsetDistance.html View 1 chunk +39 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/composition/motion-offset-composition.html View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/interpolation/motion-offset-interpolation.html View 1 chunk +0 lines, -101 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/retain-zero-percent.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/css-parser/unitless-length-quirk.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/css3/motion-path/motion-offset.html View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/ManualTests/animation/compositor-transform-fill-forwards-with-motion-path.html View 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/ManualTests/animation/compositor-transform-halted-by-motion-path.html View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/ManualTests/animation/compositor-transform-prevented-by-motion-path.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 3 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
Created Reland of CSS Motion Path: delete implementation of motion-offset property
3 years, 7 months ago (2017-05-01 05:53:44 UTC) #1
suzyh_UTC10 (ex-contributor)
lgtm
3 years, 7 months ago (2017-05-01 06:00:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856523002/1
3 years, 7 months ago (2017-05-01 06:56:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/71f3bd1682b75efac412a7431adae78afb8a903b
3 years, 7 months ago (2017-05-01 06:57:46 UTC) #11
meade_UTC10
3 years, 7 months ago (2017-05-01 07:00:01 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698