Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2841863005: CSS Motion Path: delete implementation of motion-offset property (Closed)

Created:
3 years, 8 months ago by Eric Willigers
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10, Bugs Nash
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-frames_chromium.org, chromium-reviews, dglazkov+blink, rjwright, rwlbuis, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Motion Path: delete implementation of motion-offset property The 'motion-offset' property has been replaced by 'offset-distance'. 'motion-offset' is among the properties disabled in M58. Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1MbAgAJ BUG=711937 Review-Url: https://codereview.chromium.org/2841863005 Cr-Commit-Position: refs/heads/master@{#468287} Committed: https://chromium.googlesource.com/chromium/src/+/612ac411762985a97166c4144ff0d049716a80db

Patch Set 1 #

Total comments: 3

Patch Set 2 : ManualTests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -320 lines) Patch
D third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html View 1 chunk +0 lines, -39 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/animations-responsive-offsetDistance.html View 3 chunks +6 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/composition/motion-offset-composition.html View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/interpolation/motion-offset-interpolation.html View 1 1 chunk +0 lines, -101 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/retain-zero-percent.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/css-parser/unitless-length-quirk.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/css3/motion-path/motion-offset.html View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/ManualTests/animation/compositor-transform-fill-forwards-with-motion-path.html View 1 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/ManualTests/animation/compositor-transform-halted-by-motion-path.html View 1 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/ManualTests/animation/compositor-transform-prevented-by-motion-path.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 3 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
Eric Willigers
3 years, 7 months ago (2017-04-28 01:10:12 UTC) #2
Bugs Nash
Some manual tests that use the motion-offset property: - animation/compositor-transform-halted-by-motion-path.html - animation/compositor-transform-prevented-by-motion-path.html - animation/compositor-transform-fill-forwards-with-motion-path.html https://codereview.chromium.org/2841863005/diff/1/third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html ...
3 years, 7 months ago (2017-04-30 23:42:38 UTC) #7
Eric Willigers
On 2017/04/30 23:42:38, Bugs Nash wrote: > Some manual tests that use the motion-offset property: ...
3 years, 7 months ago (2017-05-01 03:02:41 UTC) #9
Eric Willigers
https://codereview.chromium.org/2841863005/diff/1/third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html File third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html (left): https://codereview.chromium.org/2841863005/diff/1/third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html#oldcode1 third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html:1: <!DOCTYPE html> On 2017/04/30 23:42:38, Bugs Nash wrote: > ...
3 years, 7 months ago (2017-05-01 03:03:58 UTC) #10
Bugs Nash
lgtm :D https://codereview.chromium.org/2841863005/diff/1/third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html File third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html (left): https://codereview.chromium.org/2841863005/diff/1/third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html#oldcode1 third_party/WebKit/LayoutTests/animations/animations-responsive-motionOffset.html:1: <!DOCTYPE html> On 2017/05/01 at 03:03:58, Eric ...
3 years, 7 months ago (2017-05-01 03:18:12 UTC) #13
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-01 04:47:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841863005/40001
3 years, 7 months ago (2017-05-01 04:48:19 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/612ac411762985a97166c4144ff0d049716a80db
3 years, 7 months ago (2017-05-01 05:06:10 UTC) #21
suzyh_UTC10 (ex-contributor)
3 years, 7 months ago (2017-05-01 05:29:43 UTC) #22
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2856513002/ by suzyh@chromium.org.

The reason for reverting is: Speculatively reverting due to build failure on Mac
https://build.chromium.org/p/chromium/builders/Mac/builds/26841.

Powered by Google App Engine
This is Rietveld 408576698