Nodes with IDs should not be excluded as they might be the target of in-page links and attributes s…

Nodes with IDs should not be excluded as they might be the target of in-page links and attributes such as aria-labelledby.

Mostly, this affects spans with useful information that should remain in the accessibility tree.
Also took the opportunity to expose the nodes of InlineTextBoxes to the browser.
BUG=717298
R=dmazzoni@chromium.org
TESTED=Manually with Jaws and NVDA, browser tests

Review-Url: https://codereview.chromium.org/2856503003
Cr-Commit-Position: refs/heads/master@{#469693}
Committed: https://chromium.googlesource.com/chromium/src/+/7189dd39dd4b658d17bea7039546b3c2e743ada6

[nektarios, 2017-05-01 23:27:27]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 23:28:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 23:55:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 23:55:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-05-02 06:58:15]

Please put the inline text box changes in a separate patch,
they're not related to this one.

The rest looks fine, but a lot of tests may need to be updated.

[blink-reviews, 2017-05-03 15:42:43]

On 5/2/2017 2:58 AM, dmazzoni@chromium.org wrote:
> Please put the inline text box changes in a separate patch,
> they're not related to this one.

Done.

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2017-05-03 15:42:44]

On 5/2/2017 2:58 AM, dmazzoni@chromium.org wrote:
> Please put the inline text box changes in a separate patch,
> they're not related to this one.

Done.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2017-05-03 16:11:42]

lgtm assuming any changes to tests are straightforward

[nektarios, 2017-05-03 16:41:02]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 16:41:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 17:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 17:37:11]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[nektarios, 2017-05-05 01:24:09]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 01:24:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 03:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 03:15:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nektarios, 2017-05-05 14:43:58]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 14:44:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 16:40:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 16:40:41]

Dry run: This issue passed the CQ dry run.

[nektarios, 2017-05-05 17:06:29]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-05-05 17:06:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2856503003/#ps80001
(title: "Fixed Blink test.")

[commit-bot: I haz the power, 2017-05-05 17:07:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 17:14:03]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494003989195260,
"parent_rev": "93bddd53f3519c31a055cd8d27e2be2606e6eda0", "commit_rev":
"7189dd39dd4b658d17bea7039546b3c2e743ada6"}

[commit-bot: I haz the power, 2017-05-05 17:14:20]

Description was changed from

==========
Nodes with IDs should not be excluded as they might be the target of in-page
links and attributes such as aria-labelledby.

Mostly, this affects spans with useful information that should remain in the
accessibility tree.
Also took the opportunity to expose the nodes of InlineTextBoxes to the browser.
BUG=717298
R=dmazzoni@chromium.org
TESTED=Manually with Jaws and NVDA, browser tests
==========

to

==========
Nodes with IDs should not be excluded as they might be the target of in-page
links and attributes such as aria-labelledby.

Mostly, this affects spans with useful information that should remain in the
accessibility tree.
Also took the opportunity to expose the nodes of InlineTextBoxes to the browser.
BUG=717298
R=dmazzoni@chromium.org
TESTED=Manually with Jaws and NVDA, browser tests

Review-Url: https://codereview.chromium.org/2856503003
Cr-Commit-Position: refs/heads/master@{#469693}
Committed:
https://chromium.googlesource.com/chromium/src/+/7189dd39dd4b658d17bea7039546...
==========

[commit-bot: I haz the power, 2017-05-05 17:14:21]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7189dd39dd4b658d17bea7039546...