Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 2856503003: Nodes with IDs should not be excluded as they might be the target of in-page links and attributes s… (Closed)
Patch Set: Fixed Blink test. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
index 876164bc2a144bb05ead278c864326e182ec5fac..82b3c1b80ddbec7be79732bb8e529fdd1ea4720c 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
@@ -1025,8 +1025,10 @@ bool AXNodeObject::IsInPageLinkTarget() const {
return html_element->HasName() || html_element->HasID();
}
- if (element->HasID() && (IsLandmarkRelated() || isHTMLDivElement(element)))
+ if (element->HasID() && (IsLandmarkRelated() || isHTMLSpanElement(element) ||
+ isHTMLDivElement(element))) {
return true;
+ }
return false;
}
@@ -2489,8 +2491,8 @@ void AXNodeObject::TextChanged() {
}
void AXNodeObject::UpdateAccessibilityRole() {
- bool ignored_status = AccessibilityIsIgnored();
role_ = DetermineAccessibilityRole();
+ bool ignored_status = AccessibilityIsIgnored();
// The AX hierarchy only needs to be updated if the ignored status of an
// element has changed.
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698