Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2856393002: [Merge to M59] Gtk3: Fix black patches on GtkFileChooser dialogs (Closed)

Created:
3 years, 7 months ago by Tom (Use chromium acct)
Modified:
3 years, 7 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to M59] Gtk3: Fix black patches on GtkFileChooser dialogs > This CL fixes parts of GtkFileChoosers not getting rendered on GNOME > standard themes (Adwaita + HighContrast) causing black areas to > appear. > > BUG=704092 > R=erg@chromium.org > TBR=sky@chromium.org > > Review-Url: https://codereview.chromium.org/2854773002 > Cr-Commit-Position: refs/heads/master@{#468803} BUG=704092 R=erg@chromium.org TBR=sky@chromium.org NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2856393002 Cr-Commit-Position: refs/branch-heads/3071@{#390} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/05ad603540b72d126e19db8c1c2fc5aec53a4b98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -12 lines) Patch
M chrome/browser/ui/libgtkui/gtk_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.h View 2 chunks +18 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 4 chunks +47 lines, -9 lines 0 comments Download
M ui/base/glib/scoped_gobject.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Tom (Use chromium acct)
3 years, 7 months ago (2017-05-04 01:40:06 UTC) #2
Tom (Use chromium acct)
this is the merge to M59, btw
3 years, 7 months ago (2017-05-04 01:40:53 UTC) #3
sky
Please update the description to indicate this is a merge. Also, if you use drover ...
3 years, 7 months ago (2017-05-04 02:17:19 UTC) #4
Tom (Use chromium acct)
On 2017/05/04 02:17:19, sky wrote: > Please update the description to indicate this is a ...
3 years, 7 months ago (2017-05-04 02:25:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856393002/1
3 years, 7 months ago (2017-05-04 02:25:36 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 02:26:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/05ad603540b72d126e19db8c1c2f...

Powered by Google App Engine
This is Rietveld 408576698