Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2854773002: Gtk3: Fix black patches on GtkFileChooser dialogs (Closed)

Created:
3 years, 7 months ago by Tom (Use chromium acct)
Modified:
3 years, 7 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Fix black patches on GtkFileChooser dialogs This CL fixes parts of GtkFileChoosers not getting rendered on GNOME standard themes (Adwaita + HighContrast) causing black areas to appear. BUG=704092 R=erg@chromium.org TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2854773002 Cr-Commit-Position: refs/heads/master@{#468803} Committed: https://chromium.googlesource.com/chromium/src/+/ea8d1f89cb74cd379d78cf276bf6efbc3bf3ba6c

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -12 lines) Patch
M chrome/browser/ui/libgtkui/gtk_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.h View 2 chunks +18 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 1 4 chunks +47 lines, -9 lines 0 comments Download
M ui/base/glib/scoped_gobject.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Tom (Use chromium acct)
reviewers ptal erg: libgtkui sky: ui/base/glib/scoped_gobject.h
3 years, 7 months ago (2017-05-02 03:15:26 UTC) #1
Elliot Glaysher
lgtm
3 years, 7 months ago (2017-05-02 17:15:43 UTC) #2
Tom (Use chromium acct)
sky seems to be gone right now, so TBR'ing him so that I can land ...
3 years, 7 months ago (2017-05-02 21:31:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854773002/20001
3 years, 7 months ago (2017-05-02 21:32:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854773002/40001
3 years, 7 months ago (2017-05-02 22:43:41 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ea8d1f89cb74cd379d78cf276bf6efbc3bf3ba6c
3 years, 7 months ago (2017-05-02 22:49:41 UTC) #19
sky
3 years, 7 months ago (2017-05-03 03:19:15 UTC) #20
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698