Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2856273003: [Blink-scheduler] Correct description for [Background/Foreground]RendererMainThreadLoad histograms. (Closed)

Created:
3 years, 7 months ago by karandeepb
Modified:
3 years, 7 months ago
Reviewers:
Ilya Sherman, altimin
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blink-scheduler] Correct description for [Background/Foreground]RendererMainThreadLoad histograms. r413783 introduced renderer load level monitoring and introduced the RendererScheduler.[Background/ForegroundRendererMainThreadLoad] histograms. r423509 changed how often these histograms were recorded without updating the histogram descriptions. This CL updates the descriptions to correctly reflect that these are recorded at most once per minute per renderer. BUG=None Review-Url: https://codereview.chromium.org/2856273003 Cr-Commit-Position: refs/heads/master@{#469273} Committed: https://chromium.googlesource.com/chromium/src/+/77b81a68158815ad8b45bc66fd424f430cbf7da5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
karandeepb
PTAL altimin@.
3 years, 7 months ago (2017-05-03 21:23:58 UTC) #2
altimin
thanks, lgtm! +isherman@ for histograms.xml
3 years, 7 months ago (2017-05-03 21:46:02 UTC) #4
Ilya Sherman
lgtm
3 years, 7 months ago (2017-05-04 04:16:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856273003/1
3 years, 7 months ago (2017-05-04 04:16:26 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 05:21:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77b81a68158815ad8b45bc66fd42...

Powered by Google App Engine
This is Rietveld 408576698