Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2859723004: [Blink-Scheduler] Distinguish between normal and foreground-only renderers for monitoring load. (Closed)

Created:
3 years, 7 months ago by karandeepb
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, asvitkine+watch_chromium.org, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blink-Scheduler] Distinguish between normal and foreground-only renderers for monitoring load. This CL introduces the concept of a foreground-only renderer to the Blink RendererScheduler. This allows the RendererScheduler to distinguish between normal and foreground-only renderers (like extension renderers) while collecting main thread load metrics. Since this changes the semantics of the RendererScheduler.ForegroundRendererMainThreadLoad histogram (it no longer includes foreground-only renderers), it is replaced with RendererScheduler.ForegroundRendererMainThreadLoad2. Also, RendererScheduler.ForegroundOnlyRendererMainThreadLoad hisogram is introduced to collect main thread load metrics for foreground-only renderers.

Patch Set 1 #

Patch Set 2 : -- #

Patch Set 3 : --- #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -41 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h View 1 2 4 chunks +12 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 1 2 11 chunks +68 lines, -26 lines 0 comments Download
M third_party/WebKit/public/platform/scheduler/renderer/renderer_scheduler.h View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
karandeepb
The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-03 22:15:31 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859723004/20001
3 years, 7 months ago (2017-05-03 22:16:12 UTC) #2
karandeepb
Description was changed from ========== [Blink-Scheduler] Distinguish between normal and foreground-only renderers for monitoring load. ...
3 years, 7 months ago (2017-05-03 22:49:52 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-03 23:25:34 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/418146)
3 years, 7 months ago (2017-05-03 23:25:35 UTC) #5
karandeepb
The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-17 04:27:45 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2859723004/40001
3 years, 7 months ago (2017-05-17 04:29:02 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 05:52:35 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 05:52:36 UTC) #9
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698