Issue 2856233003: Change the ChangeBuilder API to use SourceRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2856233003: Change the ChangeBuilder API to use SourceRange (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson

Modified:
3 years, 7 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -39 lines)			Patch
M	pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart	View	3 chunks	+21 lines, -20 lines	0 comments	Download
M	pkg/analysis_server/lib/src/utilities/change_builder_core.dart	View	4 chunks	+11 lines, -11 lines	0 comments	Download
M	pkg/analysis_server/lib/src/utilities/change_builder_dart.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/src/utilities/change_builder_core_test.dart	View	7 chunks	+9 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

After trying to translate some of the existing code, I think this will read better ...

3 years, 7 months ago (2017-05-04 14:53:54 UTC) #2

Brian Wilkerson

3 years, 7 months ago (2017-05-04 15:49:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4a9092d9c96ba144e726d5bd9be20151f5ee3b7c (presubmit successful).