Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: pkg/analysis_server/lib/src/utilities/change_builder_dart.dart

Issue 2856233003: Change the ChangeBuilder API to use SourceRange (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/utilities/change_builder_dart.dart
diff --git a/pkg/analysis_server/lib/src/utilities/change_builder_dart.dart b/pkg/analysis_server/lib/src/utilities/change_builder_dart.dart
index 4d10048593237dcf23fbb59d52546d1f2c1a0baf..87d450051eca253d1e44e62f618deee24f193540 100644
--- a/pkg/analysis_server/lib/src/utilities/change_builder_dart.dart
+++ b/pkg/analysis_server/lib/src/utilities/change_builder_dart.dart
@@ -9,6 +9,7 @@ import 'package:analysis_server/protocol/protocol_generated.dart'
import 'package:analysis_server/src/provisional/edit/utilities/change_builder_core.dart';
import 'package:analysis_server/src/provisional/edit/utilities/change_builder_dart.dart';
import 'package:analysis_server/src/services/correction/name_suggestion.dart';
+import 'package:analysis_server/src/services/correction/source_range.dart';
import 'package:analysis_server/src/services/correction/util.dart';
import 'package:analysis_server/src/utilities/change_builder_core.dart';
import 'package:analyzer/dart/ast/ast.dart';
@@ -668,8 +669,7 @@ class DartFileEditBuilderImpl extends FileEditBuilderImpl
// wrap the existing type with Future
String returnTypeCode =
nodeCode == 'void' ? futureTypeCode : '$futureTypeCode<$nodeCode>';
- addReplacement(typeAnnotation.offset, typeAnnotation.length,
- (EditBuilder builder) {
+ addReplacement(rangeNode(typeAnnotation), (EditBuilder builder) {
builder.write(returnTypeCode);
});
}

Powered by Google App Engine
This is Rietveld 408576698