Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: pkg/analysis_server/lib/src/utilities/change_builder_core.dart

Issue 2856233003: Change the ChangeBuilder API to use SourceRange (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/utilities/change_builder_core.dart
diff --git a/pkg/analysis_server/lib/src/utilities/change_builder_core.dart b/pkg/analysis_server/lib/src/utilities/change_builder_core.dart
index cf21e8e3d3c11e8162388b7bad507b15286b5166..f5c9e9cf8ff4224528288830c9010cdc6bb68bc7 100644
--- a/pkg/analysis_server/lib/src/utilities/change_builder_core.dart
+++ b/pkg/analysis_server/lib/src/utilities/change_builder_core.dart
@@ -6,6 +6,7 @@ import 'dart:async';
import 'package:analysis_server/protocol/protocol_generated.dart';
import 'package:analysis_server/src/provisional/edit/utilities/change_builder_core.dart';
+import 'package:analyzer/src/generated/source.dart';
/**
* A builder used to build a [SourceChange].
@@ -201,8 +202,8 @@ class FileEditBuilderImpl implements FileEditBuilder {
: fileEdit = new SourceFileEdit(path, timeStamp);
@override
- void addDeletion(int offset, int length) {
- EditBuilderImpl builder = createEditBuilder(offset, length);
+ void addDeletion(SourceRange range) {
+ EditBuilderImpl builder = createEditBuilder(range.offset, range.length);
fileEdit.add(builder.sourceEdit);
}
@@ -218,17 +219,16 @@ class FileEditBuilderImpl implements FileEditBuilder {
}
@override
- void addLinkedPosition(int offset, int length, String groupName) {
+ void addLinkedPosition(SourceRange range, String groupName) {
LinkedEditGroup group = changeBuilder.getLinkedEditGroup(groupName);
- Position position =
- new Position(fileEdit.file, offset + _deltaToOffset(offset));
- group.addPosition(position, length);
+ Position position = new Position(
+ fileEdit.file, range.offset + _deltaToOffset(range.offset));
+ group.addPosition(position, range.length);
}
@override
- void addReplacement(
- int offset, int length, void buildEdit(EditBuilder builder)) {
- EditBuilderImpl builder = createEditBuilder(offset, length);
+ void addReplacement(SourceRange range, void buildEdit(EditBuilder builder)) {
+ EditBuilderImpl builder = createEditBuilder(range.offset, range.length);
try {
buildEdit(builder);
} finally {
@@ -249,8 +249,8 @@ class FileEditBuilderImpl implements FileEditBuilder {
}
@override
- void addSimpleReplacement(int offset, int length, String text) {
- EditBuilderImpl builder = createEditBuilder(offset, length);
+ void addSimpleReplacement(SourceRange range, String text) {
+ EditBuilderImpl builder = createEditBuilder(range.offset, range.length);
try {
builder.write(text);
} finally {

Powered by Google App Engine
This is Rietveld 408576698