Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2856223006: Delete chrome://net-internals/#export (Closed)

Created:
3 years, 7 months ago by eroman
Modified:
3 years, 7 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, bnc+watch_chromium.org, arv+watch_chromium.org, mmenke, eroman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete chrome://net-internals/#export This was deprecated since M58 (having been replaced by chrome://net-export/) If users still have bookmarks to #export, they will now get a dialog prompt asking them if they want to be redirected to chrome://net-export/ BUG=678386 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2856223006 Cr-Commit-Position: refs/heads/master@{#469574} Committed: https://chromium.googlesource.com/chromium/src/+/a7f495e07e33659fed8591fcabf5f3616c1042a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -359 lines) Patch
M chrome/browser/resources/net_internals/capture_view.js View 2 chunks +0 lines, -17 lines 0 comments Download
D chrome/browser/resources/net_internals/export_view.html View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/resources/net_internals/export_view.js View 1 chunk +0 lines, -202 lines 0 comments Download
M chrome/browser/resources/net_internals/index.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/net_internals/index.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/net_internals/log_util.js View 2 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/resources/net_internals/main.js View 3 chunks +22 lines, -4 lines 0 comments Download
M chrome/test/data/webui/net_internals/log_util.js View 7 chunks +5 lines, -52 lines 0 comments Download
M chrome/test/data/webui/net_internals/main.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/webui/net_internals/net_internals_test.js View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
eroman
3 years, 7 months ago (2017-05-04 00:32:00 UTC) #4
xunjieli
lgtm. The Capture tab still works, which is pretty cool. So I guess the next ...
3 years, 7 months ago (2017-05-05 00:19:46 UTC) #8
eroman
The next steps as I see them are: (1) Get the external log viewer web ...
3 years, 7 months ago (2017-05-05 01:02:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856223006/1
3 years, 7 months ago (2017-05-05 01:05:25 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 02:13:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7f495e07e33659fed8591fcabf5...

Powered by Google App Engine
This is Rietveld 408576698