Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1824)

Unified Diff: chrome/browser/resources/net_internals/capture_view.js

Issue 2856223006: Delete chrome://net-internals/#export (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/net_internals/export_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/net_internals/capture_view.js
diff --git a/chrome/browser/resources/net_internals/capture_view.js b/chrome/browser/resources/net_internals/capture_view.js
index 2d3b76fd6dfa0cd533b12e6b34c2459a6e94854e..c14f0dd154e689ad52d2d67cc909d83374e41664 100644
--- a/chrome/browser/resources/net_internals/capture_view.js
+++ b/chrome/browser/resources/net_internals/capture_view.js
@@ -30,13 +30,6 @@ var CaptureView = (function() {
$(CaptureView.RESET_BUTTON_ID).onclick =
this.onResetButtonClicked_.bind(this);
- if (byteLoggingCheckbox.checked) {
- // The code to display a warning on ExportView relies on bytelogging
- // being off by default. If this ever changes, the code will need to
- // be updated.
- throw 'Not expecting byte logging to be enabled!';
- }
-
new MouseOverHelp(
CaptureView.LIMIT_HELP_ID, CaptureView.LIMIT_HELP_HOVER_ID);
@@ -87,16 +80,6 @@ var CaptureView = (function() {
if (byteLoggingCheckbox.checked) {
g_browser.setCaptureMode('IncludeSocketBytes');
-
- // Once we enable byte logging, all bets are off on what gets captured.
- // Have the export view warn that the "strip cookies" option is
- // ineffective from this point on.
- //
- // In theory we could clear this warning after unchecking the box and
- // then deleting all the events which had been captured. We don't
- // currently do that; if you want the warning to go away, will need to
- // reload.
- ExportView.getInstance().showPrivacyWarning();
} else {
g_browser.setCaptureMode('IncludeCookiesAndCredentials');
}
« no previous file with comments | « no previous file | chrome/browser/resources/net_internals/export_view.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698