Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2856223002: Reland of Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac (Closed)

Created:
3 years, 7 months ago by msramek
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac (patchset #1 id:1 of https://codereview.chromium.org/2862583003/ ) Reason for revert: ...and relanding, because I'm trigger-happy and misread the bug report. There wasn't a problem with this reland, but with the previous one, which was already reverted. Original issue's description: > Revert of Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac (patchset #3 id:60001 of https://codereview.chromium.org/2858683003/ ) > > Reason for revert: > And reverting again, because MAYBE_ and PRE_ directives cannot be used together. > > Original issue's description: > > Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac > > > > TBR=sky@chromium.org > > BUG=717740 > > > > Review-Url: https://codereview.chromium.org/2858683003 > > Cr-Original-Commit-Position: refs/heads/master@{#468963} > > Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d0119f06c2304 > > Review-Url: https://codereview.chromium.org/2858683003 > > Cr-Commit-Position: refs/heads/master@{#469021} > > Committed: https://chromium.googlesource.com/chromium/src/+/666f9f44c4e0aa571a167f7b9b9a8c15a6a0e964 > > TBR=sky@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=717740 > > Review-Url: https://codereview.chromium.org/2862583003 > Cr-Commit-Position: refs/heads/master@{#469040} > Committed: https://chromium.googlesource.com/chromium/src/+/fe342d7b2c65097f714739bb6dabe33a1ec8b107 TBR=sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=717740 Review-Url: https://codereview.chromium.org/2856223002 Cr-Commit-Position: refs/heads/master@{#469048} Committed: https://chromium.googlesource.com/chromium/src/+/dba5cb7d9fe8705651cb0d04895dbb8ea1691421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chrome/browser/sessions/better_session_restore_browsertest.cc View 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
msramek
Created Reland of Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac
3 years, 7 months ago (2017-05-03 18:39:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856223002/1
3 years, 7 months ago (2017-05-03 18:39:44 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 18:45:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dba5cb7d9fe8705651cb0d04895d...

Powered by Google App Engine
This is Rietveld 408576698