|
|
DescriptionDisable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac
TBR=sky@chromium.org
BUG=717740
Review-Url: https://codereview.chromium.org/2858683003
Cr-Original-Commit-Position: refs/heads/master@{#468963}
Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d0119f06c2304
Review-Url: https://codereview.chromium.org/2858683003
Cr-Commit-Position: refs/heads/master@{#469021}
Committed: https://chromium.googlesource.com/chromium/src/+/666f9f44c4e0aa571a167f7b9b9a8c15a6a0e964
Patch Set 1 #Patch Set 2 : Fix the typo. #Patch Set 3 : Disabled the actual test as well. #Messages
Total messages: 29 (14 generated)
Description was changed from ========== Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac TBR=sky@chromium.org BUG=717740 ========== to ========== Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac TBR=sky@chromium.org NOTRY=True BUG=717740 ==========
Sheriff here, disabling a flaky test. sky@, I'm adding you to TBR as the only owner of the file.
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1493821814865730, "parent_rev": "d3c675e53e8b9c17d77e47107d04df8d0baae069", "commit_rev": "dd799306dbacf94b73b935d9870d0119f06c2304"}
Message was sent while issue was closed.
Description was changed from ========== Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac TBR=sky@chromium.org NOTRY=True BUG=717740 ========== to ========== Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac TBR=sky@chromium.org NOTRY=True BUG=717740 Review-Url: https://codereview.chromium.org/2858683003 Cr-Commit-Position: refs/heads/master@{#468963} Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2862553003/ by msramek@chromium.org. The reason for reverting is: Sigh... a typo. Reverting..
Message was sent while issue was closed.
Description was changed from ========== Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac TBR=sky@chromium.org NOTRY=True BUG=717740 Review-Url: https://codereview.chromium.org/2858683003 Cr-Commit-Position: refs/heads/master@{#468963} Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d... ========== to ========== Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac TBR=sky@chromium.org BUG=717740 Review-Url: https://codereview.chromium.org/2858683003 Cr-Commit-Position: refs/heads/master@{#468963} Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d... ==========
Message was sent while issue was closed.
Sorry for the noise. I thought I couldn't make a typo in such a simple CL, but I did. Fixed and landing again, this time through the trybots to make sure.
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Findit (https://goo.gl/kROfz5) confirmed this CL at revision 468963 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:40001) has been deleted
Upon closer look, I need to disable not only RestartTest.PRE_LocalStorageClearedOnExit, but also the actual RestartTest.LocalStorageClearedOnExit. Sorry for more noise, I haven't seen this construct before.
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493829290317110, "parent_rev": "d8478a85a577aa1ac3d1bfb1a6f1d81e3de9e385", "commit_rev": "666f9f44c4e0aa571a167f7b9b9a8c15a6a0e964"}
Message was sent while issue was closed.
Description was changed from ========== Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac TBR=sky@chromium.org BUG=717740 Review-Url: https://codereview.chromium.org/2858683003 Cr-Commit-Position: refs/heads/master@{#468963} Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d... ========== to ========== Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac TBR=sky@chromium.org BUG=717740 Review-Url: https://codereview.chromium.org/2858683003 Cr-Original-Commit-Position: refs/heads/master@{#468963} Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d... Review-Url: https://codereview.chromium.org/2858683003 Cr-Commit-Position: refs/heads/master@{#469021} Committed: https://chromium.googlesource.com/chromium/src/+/666f9f44c4e0aa571a167f7b9b9a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/666f9f44c4e0aa571a167f7b9b9a...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in https://codereview.chromium.org/2862583003/ by msramek@chromium.org. The reason for reverting is: And reverting again, because MAYBE_ and PRE_ directives cannot be used together.. |