Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 2858683003: Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac (Closed)

Created:
3 years, 7 months ago by msramek
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac TBR=sky@chromium.org BUG=717740 Review-Url: https://codereview.chromium.org/2858683003 Cr-Original-Commit-Position: refs/heads/master@{#468963} Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d0119f06c2304 Review-Url: https://codereview.chromium.org/2858683003 Cr-Commit-Position: refs/heads/master@{#469021} Committed: https://chromium.googlesource.com/chromium/src/+/666f9f44c4e0aa571a167f7b9b9a8c15a6a0e964

Patch Set 1 #

Patch Set 2 : Fix the typo. #

Patch Set 3 : Disabled the actual test as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chrome/browser/sessions/better_session_restore_browsertest.cc View 1 2 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 29 (14 generated)
msramek
Sheriff here, disabling a flaky test. sky@, I'm adding you to TBR as the only ...
3 years, 7 months ago (2017-05-03 14:30:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858683003/1
3 years, 7 months ago (2017-05-03 14:30:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d0119f06c2304
3 years, 7 months ago (2017-05-03 14:36:00 UTC) #7
msramek
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2862553003/ by msramek@chromium.org. ...
3 years, 7 months ago (2017-05-03 14:50:27 UTC) #8
msramek
Sorry for the noise. I thought I couldn't make a typo in such a simple ...
3 years, 7 months ago (2017-05-03 14:55:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858683003/20001
3 years, 7 months ago (2017-05-03 14:55:59 UTC) #12
findit-for-me
Findit (https://goo.gl/kROfz5) confirmed this CL at revision 468963 as the culprit for failures in the ...
3 years, 7 months ago (2017-05-03 15:00:26 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/444263)
3 years, 7 months ago (2017-05-03 15:34:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858683003/20001
3 years, 7 months ago (2017-05-03 15:42:24 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/444324)
3 years, 7 months ago (2017-05-03 16:25:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858683003/20001
3 years, 7 months ago (2017-05-03 16:27:16 UTC) #21
msramek
Upon closer look, I need to disable not only RestartTest.PRE_LocalStorageClearedOnExit, but also the actual RestartTest.LocalStorageClearedOnExit. ...
3 years, 7 months ago (2017-05-03 16:34:46 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858683003/60001
3 years, 7 months ago (2017-05-03 16:35:28 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/666f9f44c4e0aa571a167f7b9b9a8c15a6a0e964
3 years, 7 months ago (2017-05-03 17:31:22 UTC) #28
msramek
3 years, 7 months ago (2017-05-03 18:30:51 UTC) #29
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2862583003/ by msramek@chromium.org.

The reason for reverting is: And reverting again, because MAYBE_ and PRE_
directives cannot be used together..

Powered by Google App Engine
This is Rietveld 408576698